search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
545 stars 68 forks source link

Fix typo in `.dockerignore`; `git` is supposed to be `.git` #301

Closed dudeitssm closed 2 years ago

dudeitssm commented 2 years ago

Hi Xonshiz.

I am tinkering with the Docker image of this program at the moment and noticed there is possibly a typo. Adding .git inside .dockerignore shaves off about 60MB from the image.

P.S. I believe I have an Alpine Linux based image that is ready for beta testing. I will make a PR about that shortly, after I test out a few other things. Long story short, I managed to get it down to about ~100MB (almost 2/3rd size reduction).

(I have so far tested out downloading manga, and it works :smile_cat: )

localhost/msl-comic-dl             latest           a7ba8426afb1  32 minutes ago  94.9 MB
localhost/comic-dl                 py3.8-buster     b4bf0219d6f1  23 hours ago    285 MB
Xonshiz commented 2 years ago

Thanks a ton for noticing and fixing it! :)

darodi commented 2 years ago

@dudeitssm My bad, this was indeed a typo. Thanks for the correction.

For your information, I used a python slim debian image because of those remarks:

Standard PyPI wheels don’t work on Alpine

However, some teams are moving away from alpine because these images can cause compatibility issues that are hard to debug. Specifically, if using python images, some wheels are built to be compatible with Debian and will need to be recompiled to work with an Apline-based image.

and I was also trying to build an arm v7 image.

see

If it works for your arch and it's smaller, why not. It's still a good idea to add another Dockerfile with an alpine base image.

@Xonshiz It would be great to create a pipeline to make the docker images built and released automatically by github. I'll try to create a PR with that.

Xonshiz commented 2 years ago

Yeah, sounds like a good idea to create that pipeline. I'll try to spend some time this weekend to look into this. I see some intermittent issues with the current release pipeline. It's a bit wonky atm, have to fix that as well.