search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
545 stars 68 forks source link

docker build pipeline #302

Closed darodi closed 2 years ago

darodi commented 2 years ago

docker build pipeline

Xonshiz commented 2 years ago

Will get this in and then try to spend some time revisiting the Travis build. It's.. uh...flaky.

darodi commented 2 years ago

@Xonshiz

Strange, the pipeline didn't run:

build_and_push / Prepare workflow environment The hosted runner: Hosted Agent lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

Could you try running it again? https://github.com/Xonshiz/comic-dl/actions

It works fine on my fork https://github.com/darodi/comic-dl/actions

Xonshiz commented 2 years ago

yeah I ran it again. Probably timing out.

Xonshiz commented 2 years ago 
error: invalid tag "ghcr.io/Xonshiz/comic-dl:2022.04.09_linux_amd64_nohealthcheck": repository name must be lowercase
Error: buildx failed with: error: invalid tag "ghcr.io/Xonshiz/comic-dl:2022.04.09_linux_amd64_nohealthcheck": repository name must be lowercase

That Xonshiz got it lol.

darodi commented 2 years ago

I'm creating a separated base image for python + pikepdf. It doesn't make sense to build pikepdf every time a line of code is changed in comic-dl. I'll create a PR once the base docker image is built.

Télécharger Outlook pour Androidhttps://aka.ms/AAb9ysg

From: Dhruv Kanojia (Xonshiz) @.> Sent: Saturday, April 9, 2022 1:47:45 PM To: Xonshiz/comic-dl @.> Cc: darodi @.>; Author @.> Subject: Re: [Xonshiz/comic-dl] docker build pipeline (PR #302)

yeah I ran it again. Probably timing out.

― Reply to this email directly, view it on GitHubhttps://github.com/Xonshiz/comic-dl/pull/302#issuecomment-1093951235, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDXITQ3L47EVZQ5FDSNKI3VEFU6DANCNFSM5S553OMQ. You are receiving this because you authored the thread.Message ID: @.***>

Xonshiz commented 2 years ago

Yeah, that makes sense. While you do that, I'm looking into porting this complete pipeline from Travis to GH Actions. Travis has been buggy for a while now.