Closed darodi closed 2 years ago
@Xonshiz
I saw https://github.com/Xonshiz/comic-dl/commit/b75d2adea49308905b2bd48051c37cb44eb4eadc
you should still use
${{ github.repository_owner }}
instead.
the github workflow now uses:
uses: darodi/common-github-workflows/.github/workflows/build_and_push_image.yml@main
and I changed the workflow to use lower case for ghcr.io https://github.com/darodi/common-github-workflows/commit/4befed02648c7d9ea21651cec576163006b1ab93
You shouldn't have the following error:
Error: buildx failed with: error: invalid tag "ghcr.io/Xonshiz/comic-dl:2022.04.09_linux_amd64_nohealthcheck": repository name must be lowercase
I've reverted it back now. Had changed it few minutes back because it was still failing. I've triggered it again, let's see how it goes in.
@darodi looks like it's still failing. Could it be because L494 in workflow references needs.workflows_env.outputs.ghcr_repo_owner
instead of needs.workflows_env.outputs. workflow_env_ghcr_repo_owner
?
Because you're setting that one to lower?
I found another part of the workflow where the lowercase wasn't done, I fixed it.
IMAGE_NAMES+=("ghcr.io/${{ github.repository }}")
https://github.com/darodi/common-github-workflows/commit/de3be51ebb715319bc0518c006698759bb0b7f57
@Xonshiz
Could you try again with this fix?
I re-ran the wf... still the same thing.
@Xonshiz
My bad...
There where many steps image_names_tags
.
I had only changed one of them.
All of them are changed now. https://github.com/darodi/common-github-workflows/commit/82ff484d6520170ed44a1afd92ed617bac861e21
We will get there...
Can you re-run?
Hahahahahahha Sure, yeah, running again :D
@Xonshiz
seems ok now. Don't forget to make the package public instead of private
https://github.com/users/Xonshiz/packages?repo_name=comic-dl
Yes, just did. Again, thanks a ton for all the hard work on @darodi :)
move py3.8-slim-buster-pikepdf to its own docker image for arm
I also changed the workflow used to work with Upercase github username/repository name It uses: darodi/common-github-workflows/.github/workflows/build_and_push_image.yml@main
to prevent error: Error: buildx failed with: error: invalid tag "ghcr.io/Xonshiz/comic-dl:2022.04.09_linux_amd64_nohealthcheck": repository name must be lowercase