search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
538 stars 68 forks source link

improve ignores #316

Closed darodi closed 2 years ago

darodi commented 2 years ago

improve ignores

darodi commented 2 years ago

added cookie in config.json.example or you might get: 

d:\downloads\Apps\comic-dl>cli.py -a
Traceback (most recent call last):
  File "D:\downloads\Apps\comic-dl\cli.py", line 7, in <module>
    main()
  File "D:\downloads\Apps\comic-dl\comic_dl\__main__.py", line 15, in main
    ComicDL(sys.argv[1:])
  File "D:\downloads\Apps\comic-dl\comic_dl\comic_dl.py", line 214, in __init__
    manual_cookie = data["cookie"]
KeyError: 'cookie'
Xonshiz commented 2 years ago

@darodi could you please address that comment I added in the previous .dockerignore file? I'll merge this PR.

Also, thanks for catching that missing cookie.

darodi commented 2 years ago

I don't see, where is the comment?

Xonshiz commented 2 years ago

.dockerignore line 12. Instead of "changelog.md, could you make it*.md. Better ignore all.md` files instead of changelog.