search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
550 stars 68 forks source link

Download directory #93

Closed ducle2502 closed 6 years ago

ducle2502 commented 6 years ago

I am using the 2018.01.22 windows binary release and I notice that the downloader creates a folder named "D" and saves all the comics there instead of the folder it is in. In previous releases it would just put the comics where it is. Is this an intended feature?

Xonshiz commented 6 years ago

Hey, please write a proper report, as mentioned in the read me, along with the verbose output log.

StrangeDOS commented 6 years ago

ducle2502, There is a switch you can use to control where your files are downloaded to (--dd). This allows you to put your files where ever you like.

Example: comic_dl -i http://readcomiconline.to/Comic/DreamWorks-Dragons-Riders-of-Berk -dd f:\DownloadComic

In the example above, I'm downloading to the 'DownloadComic' folder on my F: drive.

If you aren't experiencing that, be sure to run a test using the --verbose switch and post the Error_Log so Xonshiz can see what happened.

Xonshiz commented 6 years ago

I'm just confused about this particular line :

I notice that the downloader creates a folder named "D" and saves all the comics there instead of the folder it is in.

I need a verbose log for this part. This is a weird behavior. Because when I tested the script on my end, it worked just fine.

ducle2502 commented 6 years ago

This is the log for the issue. The command I input was: comic_dl.exe -i http://readcomiconline.to/Comic/Books-of-Magick-Life-During-Wartime --convert cbz --keep no -v As can be seen from the log, the downloader saves the files to "D:\Ebooks\D\" while normally it would save it to "D:\Ebooks", where I keep the comic_dl.exe file.

On Mon, Jan 22, 2018 at 11:05 PM, Dhruv Kanojia (Xonshiz) < notifications@github.com> wrote:

I'm just confused about this particular line :

I notice that the downloader creates a folder named "D" and saves all the comics there instead of the folder it is in.

I need a verbose log for this part. This is a weird behavior. Because when I tested the script on my end, it worked just fine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Xonshiz/comic-dl/issues/93#issuecomment-359471988, or mute the thread https://github.com/notifications/unsubscribe-auth/AYke4ZJomueCDxb6BXk9lYr07YLUVm9Yks5tNLHLgaJpZM4RmPw3 .

-- Mr. LE MINH HONG DUC LOGISTICS AND SUPPLY CHAIN MANAGEMENT INTERNATIONAL UNIVERSITY Phone: (+84)906 321 394 Email: ducle2502@gmail.com

Xonshiz commented 6 years ago

Could you please upload the log again? I cannot see any attachment.

ducle2502 commented 6 years ago

Here is the log. Error_Log.log

StrangeDOS commented 6 years ago

ducle2502, in the short term, you can use the --dd switch to put your files in the directory that you want. Example:

comic_dl.exe -i http://readcomiconline.to/Comic/Books-of-Magick-Life-During-Wartime --convert cbz --keep no --dd d:\Ebooks

Xonshiz, sorry I missed this bug. I always use the --dd switch, so I wouldn't have noticed it. Could this be something like a weird PATH statement? Maybe we should get ducle to post his PATH environment variable. I notice that I've got nodejs in my PATH. image

If he's got something like D:\Ebooks\D, that might explain it. Or maybe that's where nodejs is....in that d:\ebooks\d\ directory.

Xonshiz commented 6 years ago

I looked at the Error log and I tried the script on my end as well. Everything is working just fine. This is a weird issue. @ducle2502 , could you please post your system path variable settings, like @StrangeDOS did above?