search

XoopsModules25x / news

With this XOOPS module, you can create an unlimited number of news on your site. You can create all the articles you want and attach them to topics.
4 stars 11 forks source link

Made checking "Approve" by default for module admin users configurable. #32

Closed Andrew-Staves-Activ closed 2 years ago

Andrew-Staves-Activ commented 2 years ago

Via a new option in the module's preferences. The intention is to allow users who happen to be module administrators (because, e.g., they're webmasters) to still treat approval as a two-stage process by default - like users who are not module admins.

mambax7 commented 2 years ago

I am not sure about it - as a Webmaster, I don't want to go through the extra steps when I install a module. Maybe it would be better to do the reverse, i.e. if the Webmaster doesn't want to be approved automatically, then s/he can turn off this behavior?

Andrew-Staves-Activ commented 2 years ago

I am not sure about it - as a Webmaster, I don't want to go through the extra steps when I install a module. Maybe it would be better to do the reverse, i.e. if the Webmaster doesn't want to be approved automatically, then s/he can turn off this behavior?

I'm not sure what you mean by doing the reverse, as this doesn't relate to the automatic approval functionality. Though I may well be misunderstanding you - I apologise if that is the case. This change does not (directly) relate to the automated approval, it's separate and doesn't change any behaviour by default, it only provides an additional option to change some default behaviour: image (The change adds the last option in this picture.)

If this new option is changed to "No" and a user with module admin rights (for news) loads one of the story forms for adding a news article, they will find that the "Approve" checkbox is unchecked. Therefore they experience the same behaviour as a non-module admin user. Which allows them to participate in, e.g., a process where one user submits a news article and a different user reviews it before publishing it. With the new option set to "Yes", i.e., the current behaviour, a news module admin would have to manually untick "Approve" every time to participate in such a process. This is more-or-less the scenario that led to developing this change - we have users with web master rights who also happen to write stories and we would like them to follow the same process as regular users. Of course, they could untick "Approve" but if they forget to do so, there's no way to undo sending out all of the notification emails.

This should not affect the separate, pre-existing, "Auto approve news stories without admin intervention?" option. I hope that makes sense, please do let me know if not.

mambax7 commented 2 years ago

Sorry, my misunderstanding! Thanks for the clarification!

Andrew-Staves-Activ commented 2 years ago

Sorry, my misunderstanding! Thanks for the clarification!

No worries, thanks for merging 🙂