XoopsX / legacy

XOOPS Cube Legacy base repository
15 stars 11 forks source link

Fixes for PHP7.2 #84

Closed shirosaki closed 6 years ago

shirosaki commented 6 years ago

PHP 7.2 環境で出たerror, warningなどの修正を行いました。

nao-pon commented 6 years ago

@shirosaki Thank you for your contributes! 👍 About constructor, It should be support to old style parent::CLASS NAME() for old modules.

for example in XoopsPageNav ...

public function XoopsPageNav($total_items, $items_perpage, $current_start, $start_name="start", $extra_arg="")
{
    return self::__construct($total_items, $items_perpage, $current_start, $start_name, $extra_arg);
}

public function __construct($total_items, $items_perpage, $current_start, $start_name="start", $extra_arg="")
shirosaki commented 6 years ago

Thanks for review. Added old style constructor for html/class/* and html/kernel/*.

nao-pon commented 6 years ago

@shirosaki Thanks! but it seems missing keyword self::.

shirosaki commented 6 years ago

Sorry. Updated to add self:: and added some constructor fixes for modules.

nao-pon commented 6 years ago

@shirosaki Thanks! 👍