XorTroll / emuiibo

Virtual amiibo (amiibo emulation) system for Nintendo Switch
GNU General Public License v2.0
1.14k stars 84 forks source link

Some images too big #221

Open cherubyn opened 1 year ago

cherubyn commented 1 year ago

When generating amiibos some generated images are too big. For example: "Legend of Zelda" -> "Daruk" or "Mipha". Images are not shown in Tesla emuiibo menu. Instead a text "Image too big" is shown. I've ran a few tests -> your generated Daruk image was 1.6 Mb big - I resized it down to about 140 kb to get it to work. Would be awesome if you could fix that!

MSco commented 1 year ago

Following images are too big: The Legend Of Zelda: Daruk, Mipha, Revali, Urbosa

In addition to that, the following amiibo image has the wrong RGB format (gimp says built-in RGB) and also cannot be displayed in emuiibo: Super Smash Bros: Byleth

P.S.: I only checked The Legend Of Zelda, Super Smash Bros, Pokemon and Metroid. So there may be more amiibo images broken outside of those directories.

jacoghi commented 1 year ago

Not really the application's fault, emutool just downloads the files from the amiiboapi, located here: https://www.amiiboapi.com/api/amiibo/ If you check the specific problematic images, you'll notice their resolution is way higher than the other images, so maybe a request should be opened in that repo to have all images standardized to the same width or height?

DeadlyVoyage commented 1 year ago

@jacoghi, why would the AmiiboAPI dev's shrink their images and reduce the image quality just to work with emuiibo? Wouldn't it make more sense for the emuiibo dev's to code emuiibo so that it can handle the larger images? That's just dumb logic.

impeeza commented 1 year ago

Calling dumb to somebody is giving their time am efforts is no so polite, yes to can nicely all for a enhancement. And yes could be good idea to the emuiibo tool be able to fit larger/smaller pictures on the gui

DeadlyVoyage commented 1 year ago

@impeeza, it's painfully obvious that English isn't your first language. Perhaps you should go back and read my post again a few more times so you can properly comprehend the entire thing, because it appears the only thing you read was the last sentence. Perhaps you should also take note that @jacoghi reacted to my post with a "Laughing" Emoji. So there's no need to be such a snowflake.