XorTroll / uLaunch

:rocket: The themeable Nintendo Switch HOME menu Nintendo forgot to make
https://xortroll.github.io/uLaunch/
GNU General Public License v2.0
602 stars 56 forks source link

Custom menu entries - change only icon/name/author/version #239

Open ThatFinnDev opened 1 month ago

ThatFinnDev commented 1 month ago

When editing a menu entry JSON file to add a custom icon via "custom_icon_path", you need to specify "custom_name", "custom_author" or "custom_version" as well, for the custom icon to be applied. Also, when you're not using all arguments (custom_name", "custom_author", "custom_version" and "custom_icon_path"), the info will all be ???.

XorTroll commented 1 month ago

SdOut.zip

Can you tell me if this version fixes these issues?

ThatFinnDev commented 1 month ago

Um, i can't log into my user with this version. Controller input is broken. I can select my user and "add user" via the touch screen, but i cant login.

XorTroll commented 1 month ago

I've also been testing changes with input, what are the controller(s) you're using?

ThatFinnDev commented 1 month ago

Joy cons (connected to the switch, wired)

ThatFinnDev commented 1 month ago

I can use the joy cons wirelessly and the fix worked

ThatFinnDev commented 1 month ago

The homebrew delay deleting bug fix also works. The settings crash in this build (but i guess you already know that). Also, i just figured out that the icon and info for some homebrew applications like JSKV are broken (the info is all ???, and the icon is also ?). But this is also the case in the normal release of uLaunch.

XorTroll commented 1 month ago

I fixed the delay issue before, yeah Settings shouldn't crash, but they are still being polished I still need to look into issues with some homebrew titles/icon/etc

I reproduced the issue with attached joycons, this build makes it work for me, could you check it?

SdOut.zip

ThatFinnDev commented 1 month ago

Yup, the controller input works now :).

One more thing, i don't know if you know about sys-tweak (a sysmodule, which allows you to change icon/author/version/gamename in the normal switch home menu). It only works partially in uLaunch. Only custom icons work and they stop working if you reset the menu cache in uManager, but I guess it doesn't matter since uLaunch has its own way to customize icons and other ncap info.

Are you planning to keep the customization this way or are you going to add easier custom icon support in the future (by just adding a icon.png to atmosphere/contents/titleid/icon.png)

XorTroll commented 1 month ago

I'll most likely keep it this way since I feel it allows for more flexibility of specifying icons

About the homebrew issue, would you mind to upload here a zip with the contents of the folder at "/ulaunch/cache/hb" in your SD? It's just cache'd icons and nacp data, but I'm curious about the issue of homebrew strings/icon not loading fine

ThatFinnDev commented 1 month ago

Sure, here it is. I've checked and the icon for jksv exists and the ncap file for jksv also exists and is valid.

hb.zip

XorTroll commented 1 month ago

Have you downloaded JKSV after you got uLaunch, and without rebooting the console? Or did you already have JKSV before installing uLaunch?

ThatFinnDev commented 1 month ago

I already had it

ThatFinnDev commented 1 month ago

The settings menu crash only occurs when I am connected to wifi. This crash occurs in the latest dev build on discord as well

Edit: Found the problem, the system update status thing crashes it. If you have the Nintendo servers (or just telemetry servers) blocked (telemetry servers are blocked by default), the settings menu can't get the system update status and it crashes. To fix the crash you have to either enable airplane mode, so you're not connected to wifi or you have to unblock the nintendo servers manually. I do not recommend unblocking Nintendo servers because you can get banned, my switch is already banned which is why I unblocked them to test it

XorTroll commented 1 month ago

Could you test this build? Should fix the system update issue (should complain about lack of connection instead of just crashing) and might have done something about homebrew not showing properly in menu

SdOut.zip

ThatFinnDev commented 1 month ago

It fixes the crashing issue, but doesn't fix the homebrew issue. There is also a new issue. When you try to add a homebrew to the home menu. Instead of the hb selector, I just get a black screen and pressing home or b does nothing. I have to reboot to fix it

Edit: launching any game/homebrew also causes the black screen (it doesn't matter if in applet or application mode)