Xovos / esx_illegal

I changed ESX_Drugs and added a lot of features like more drugs and licenses for the money was and the money wash itself.
GNU General Public License v3.0
16 stars 16 forks source link

menu issues #20

Closed Danny9865 closed 4 years ago

Danny9865 commented 4 years ago

before you open a menu, so when you're stood with the option to open a menu in the corner, the ms and ram usage goes through the roof. this is an issue if there's more than one person stood there. This is so high at the license area that i removed the license shop, but now i've noticed this is the same issue where you wash dirty money. when you open the menu the ms drops but just having the menu option where it says press E to open. that part goes crazy. Any chance you could take a look at this

Xovos commented 4 years ago

Hi

I have some questions to help me figure this out: Does this only happin when you're not alone in the circle? How much does it spike? 1gb 5gb? How much ram does your system have? How do you mesure the ms? how much does it spike?

Danny9865 commented 4 years ago

hi mate, i was using resmon to see it, idle not close to it the cpu was sitting at around 0,04 ms but then as soon as one player walks into the radius for the menu it goes to 0.30 ms and for the memory its not that its high its that it climbs quick and doesnt stop climbing, within about 3 minutes it gives an es-extended resource warning. ram wise we run a 64gb dedicated server on OVH. it seems to climb at both the conversion point and the monewash location. but the most extreme was where you bought the licenses so for the time being ive got rid of that and put the licenses in a shop. image picture above was at money wash, seems to loop ok but it bounces quite high.

image picture above was at the chem conversion area. tbh looking at both of these they arent too bad they loop back down. Just the menu for the licenses that was too high

Xovos commented 4 years ago

Thank you For the answers I will look into it. one more question are you running the latest (master) or the pre-limit-update version of the script?

Danny9865 commented 4 years ago

image that was putting the license shop back in btw

running the master mate as we're running esx 1.2 now

Xovos commented 4 years ago

Hi

I couldn't recreate the issue because i don't have anyone to test it with and my testserver is running on linux. I did however clean up the code. I hope this resolves the problem a bit if not completely.

Danny9865 commented 4 years ago

appreciate it mate,

image noticed this gets spammed when they pick up drugs from certain plants, im not 100% sure which ones yet. just wandered if you knew much about it

Xovos commented 4 years ago

Hi

I did get that once, but I can't get it to come up again though. Google tells me it has something to do with a full inventory but I don't know, I didn't even change anything from the pickup code.

Danny9865 commented 4 years ago

image god knows its on a mad one lol, doesn't actually seem to affect anything, looks ugly console side, il do some digging

Danny9865 commented 4 years ago

any way to make it so cops have to be online to do the drugs?

Xovos commented 4 years ago

Hi

If you find something contact me please. The Latest version of the script contains the option for the cops. Did my changes, fix the ram and ms issue? If you don't like to communicate this way you can add me on discord that's always easier. Xovos#7610