Xpndable / DotUI

MiniUI port for Miyoo Mini+
89 stars 12 forks source link

Add autosave/autoload feature #16

Closed goweiwen closed 1 year ago

goweiwen commented 1 year ago

Introduction

This PR adds an autosave/autoload feature and makes it the default behaviour:

Some changes are required to the picoarch submodule. If you plan to merge this, I suggest forking picoarch and merging those changes as well.

Details

Main Menu

mmenu

picoarch

Xpndable commented 1 year ago

This will be tested soon, now that v1.0 is close to release, thank you for your efforts 😊

anzz1 commented 1 year ago

This should definitely be configurable, either by an advanced setting or a compile-time flag.

As this is not a case of a "missing feature", but rather a conscious design decision. It wasn't that when designing MiniUI the autosave/load couldn't be added (as is apparent from autosave/load existing when powering off while in-game), but that it shouldn't be added.

Quite probably many fans of MiniUI appreciate this design decision, where Quit means Quit and Save means Save, and A cold boots a game while X resumes from last save if available. I wouldn't reverse that design decision lightly, at very least a big design change like this should be made configurable and not forced upon anyone.

Obviously there are also people who dislike the current design and would prefer the automatic saving/loading instead, so a choice between the two wouldn't be a bad idea.

goweiwen commented 1 year ago

I agree, and this PR touches too many core components to be merged regardless. Closing this for now, thanks.