search

Xpndable / DotUI

MiniUI port for Miyoo Mini+
89 stars 12 forks source link

Kill telnetd during startup to prevent security vuln #17

Open ea-dot-codes opened 1 year ago

Xpndable commented 1 year ago

This will be pulled in shortly - wasn't an issue for the v1.0 release because there is currently no WiFi configuration capability in DotUI

ericanderson commented 1 year ago

I got my device and started reverse engineering for a day before heading on holiday. I wasn't sure if previously configuring wifi would keep this on

anzz1 commented 1 year ago

This is definitely a good idea and should be added when the wifi functionality is introduced.

However I'd make a tiny change, move the killall to launch.sh where the actual launch script is. No functional difference, just keeping in line with the current structure. Tidiness is next to godliness, they say :smile: https://github.com/Xpndable/DotUI/blob/35346971efbb0c261c5042ee2cfbc283fc53bfbb/skeleton/.system/paks/MiniUI.pak/launch.sh#L32