Xpndable / DotUI

MiniUI port for Miyoo Mini+
89 stars 12 forks source link

Lower minimum brightness value to 3 #19

Closed ishabalin closed 1 year ago

ishabalin commented 1 year ago

To better match minimum brightness on MinUI for RG35XX.

Xpndable commented 1 year ago

Hi, I like this, but I might edit it to implement an exponential curve instead, stepping from 3 to 10 brightness on the 0-1 step seems to be a big leap

ishabalin commented 1 year ago

Hi, I like this, but I might edit it to implement an exponential curve instead, stepping from 3 to 10 brightness on the 0-1 step seems to be a big leap

The way I interpret the code it goes 3, 10, 20, ... with intervals 7, 10, 10, ... vs. originally 6, 10, 20, ... with intervals 4, 10, 10, ..., although I'm not sure how these numbers translate to perceived brightness. I'm fine either way as long as there's a minimum possible brightness setting 😁

Xpndable commented 1 year ago

I'd still like to credit you with the idea of the brightness floor - this is my implementation for reference:

void SetBrightness(int value) {
    if (value > 2) {
        SetRawBrightness(pow(value,2));
    } else {
        SetRawBrightness(3+(value*2));
    }
    settings->brightness = value;
    SaveSettings();
}

The end result of this is the series: (3, 5, 7, 9, 16, 25, 36, 49, 64, 81, 100) which feels a little cleaner to me in practice.