search

Xportability / css-to-pdf

Convert any HTML page or region to PDF - supports CSS, SVG, embedded XML objects, and more..
http://www.cloudformatter.com/CSS2Pdf
207 stars 77 forks source link

Suggestion: Protocol-less urls for the services #16

Open reddo opened 8 years ago

reddo commented 8 years ago

Regarding this: https://github.com/Xportability/css-to-pdf#if-you-are-calling-the-library-from-a-secure-site

Why not use protocol-less urls, like so: 

xep_chandra_service: '//xep.cloudformatter.com/Chandra.svc/genpackage',
xep_chandra_service_AS_PDF: '//xep.cloudformatter.com/Chandra.svc/genfile',
xep_chandra_service_page_images: '//xep.cloudformatter.com/Chandra.svc/genpageimages',

I've tried it in my instance and it seems to work. Some more testing might be needed though.

kbrown01 commented 8 years ago

Yes, that should work without issue.

We can change documentation.

Thanks,

Kevin Brown

From: Zoltan Balogh [mailto:notifications@github.com] Sent: Tuesday, November 24, 2015 6:20 AM To: Xportability/css-to-pdf css-to-pdf@noreply.github.com Subject: [css-to-pdf] Suggestion: Protocol-less urls for the services (#16)

Regarding this: https://github.com/Xportability/css-to-pdf#if-you-are-calling-the-library-from-a-secure-site

Why not use protocol-less urls, like so: xep_chandra_service: '//xep.cloudformatter.com/Chandra.svc/genpackage', xep_chandra_service_AS_PDF: '//xep.cloudformatter.com/Chandra.svc/genfile', xep_chandra_service_page_images: '//xep.cloudformatter.com/Chandra.svc/genpageimages',

I've tried it in my instance and it seems to work. Some more testing might be needed though.

— Reply to this email directly or view it on GitHub https://github.com/Xportability/css-to-pdf/issues/16 . https://github.com/notifications/beacon/AAsJoysEvOykHSoKt2lj0riE_yAAEaT1ks5pJGmogaJpZM4GoZzc.gif