Xposed-Modules-Repo / com.github.dan.nostoragerestrict

NoStorageRestrict
https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict
GNU General Public License v3.0
299 stars 15 forks source link

Android 14 doesn't work #10

Closed riyadmondol2006 closed 4 months ago

DanGLES3 commented 6 months ago

Could you be more specific? When selecting folders on Android 14 does the /downloads and the root of the internal storage have the grant access button grayed out?

riyadmondol2006 commented 6 months ago

none of team brother

On Tue, Dec 19, 2023, 10:43 PM DanGLES3 @.***> wrote:

Could you be more specific? When selecting folders on Android 14 does the /downloads and the root of the internal storage have the grant access button grayed out?

— Reply to this email directly, view it on GitHub https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10#issuecomment-1863116365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ72HDXU3AHKUJI7CKQRE23YKG7Z3AVCNFSM6AAAAABADN6OQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGEYTMMZWGU . You are receiving this because you authored the thread.Message ID: <Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10/1863116365 @github.com>

riyadmondol2006 commented 6 months ago

in android 14 it has no effect

DanGLES3 commented 6 months ago

none of team brother On Tue, Dec 19, 2023, 10:43 PM DanGLES3 @.***> wrote: Could you be more specific? When selecting folders on Android 14 does the /downloads and the root of the internal storage have the grant access button grayed out? — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ72HDXU3AHKUJI7CKQRE23YKG7Z3AVCNFSM6AAAAABADN6OQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGEYTMMZWGU . You are receiving this because you authored the thread.Message ID: <Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10/1863116365 @github.com>

Could you show me a screenshot?

riyadmondol2006 commented 6 months ago

to be specific what screen screenshot you want?

DanGLES3 commented 6 months ago

to be specific what screen screenshot you want?

That shows the module not working (as in not being able to select the downloads or internal storage as folders on apps)

riyadmondol2006 commented 6 months ago

[

https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict/assets/71279502/530feee9-7ce0-4cb9-b417-88dc5fd6b402

](url)

DanGLES3 commented 6 months ago

Send me the Lsposed logs

riyadmondol2006 commented 6 months ago

LSPosed_2023-12-21T03_27_42.122704.zip

DanGLES3 commented 6 months ago

LSPosed_2023-12-21T03_27_42.122704.zip

Send the external storage APK

riyadmondol2006 commented 6 months ago

External Storage_14 apk rename it to apk and should be fine As i can see maybe randomizing strings may work . Screenshot_20231221-074538

DanGLES3 commented 6 months ago

External Storage_14 apk rename it to apk and should be fine As i can see maybe randomizing strings may work . Screenshot_20231221-074538

app-release.zip

Try this (the apk is inside the zip), seems Google changed the method name in A14 QPR2

riyadmondol2006 commented 6 months ago

Ya i noticed it. Randomizing strings in dalvik should do the job..

On Thu, Dec 21, 2023, 8:04 AM DanGLES3 @.***> wrote:

[image: External Storage_14 apk] https://private-user-images.githubusercontent.com/71279502/292063092-fb775750-ca1e-487b-8fa9-a5195262f671.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMxMjQwODQsIm5iZiI6MTcwMzEyMzc4NCwicGF0aCI6Ii83MTI3OTUwMi8yOTIwNjMwOTItZmI3NzU3NTAtY2ExZS00ODdiLThmYTktYTUxOTUyNjJmNjcxLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIyMVQwMTU2MjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iZWMzNzRiYzViNzE1ZWY5NzYwZTg5MzU2N2FkOWVhNzk2NjVjOGYwZWU5NjEyYzU5ZDcwMmJmODc0OTlkMjQ4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.yg0FsYiuiB6OQ0ocLm93s_8PykZaP2kwL75_KQSYODc rename it to apk and should be fine As i can see maybe randomizing strings may work . [image: Screenshot_20231221-074538] https://private-user-images.githubusercontent.com/71279502/292063174-2b31be59-a912-40af-a4f0-f204f613773f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMxMjQwODQsIm5iZiI6MTcwMzEyMzc4NCwicGF0aCI6Ii83MTI3OTUwMi8yOTIwNjMxNzQtMmIzMWJlNTktYTkxMi00MGFmLWE0ZjAtZjIwNGY2MTM3NzNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjIxVDAxNTYyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4ZGQ0NjYwZjdhOWVhZGEwZjFiMjZiZjYwNzIyNGNkMjMzYWFiNWZkY2IyNjliZWEwMWQwNWFmMGNjNmQyMzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pEHPIZDkrLfvbhCAbzebibuL4oFhcs2_6KkpWtsWDz4

app-release.zip https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict/files/13734244/app-release.zip

Try this, seems Google changed the method name in A14 QPR2

— Reply to this email directly, view it on GitHub https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10#issuecomment-1865373218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ72HDTMVWA575KOSHP7L2DYKOKJTAVCNFSM6AAAAABADN6OQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGM3TGMRRHA . You are receiving this because you authored the thread.Message ID: <Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10/1865373218 @github.com>

DanGLES3 commented 6 months ago

Ya i noticed it. Randomizing strings in dalvik should do the job.. On Thu, Dec 21, 2023, 8:04 AM DanGLES3 @.***> wrote: [image: External Storage_14 apk] https://private-user-images.githubusercontent.com/71279502/292063092-fb775750-ca1e-487b-8fa9-a5195262f671.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMxMjQwODQsIm5iZiI6MTcwMzEyMzc4NCwicGF0aCI6Ii83MTI3OTUwMi8yOTIwNjMwOTItZmI3NzU3NTAtY2ExZS00ODdiLThmYTktYTUxOTUyNjJmNjcxLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIyMVQwMTU2MjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iZWMzNzRiYzViNzE1ZWY5NzYwZTg5MzU2N2FkOWVhNzk2NjVjOGYwZWU5NjEyYzU5ZDcwMmJmODc0OTlkMjQ4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.yg0FsYiuiB6OQ0ocLm93s_8PykZaP2kwL75_KQSYODc rename it to apk and should be fine As i can see maybe randomizing strings may work . [image: Screenshot_20231221-074538] https://private-user-images.githubusercontent.com/71279502/292063174-2b31be59-a912-40af-a4f0-f204f613773f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMxMjQwODQsIm5iZiI6MTcwMzEyMzc4NCwicGF0aCI6Ii83MTI3OTUwMi8yOTIwNjMxNzQtMmIzMWJlNTktYTkxMi00MGFmLWE0ZjAtZjIwNGY2MTM3NzNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjIxVDAxNTYyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4ZGQ0NjYwZjdhOWVhZGEwZjFiMjZiZjYwNzIyNGNkMjMzYWFiNWZkY2IyNjliZWEwMWQwNWFmMGNjNmQyMzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pEHPIZDkrLfvbhCAbzebibuL4oFhcs2_6KkpWtsWDz4 app-release.zip https://github.com/Xposed-Modules-Repo/com.github.dan.nostoragerestrict/files/13734244/app-release.zip Try this, seems Google changed the method name in A14 QPR2 — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ72HDTMVWA575KOSHP7L2DYKOKJTAVCNFSM6AAAAABADN6OQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGM3TGMRRHA . You are receiving this because you authored the thread.Message ID: <Xposed-Modules-Repo/com.github.dan.nostoragerestrict/issues/10/1865373218 @github.com>

i've added an additional hook to target this new class name, so it should work, kindly test it if possible

buttercookie42 commented 6 months ago

According to the source code, the method name ultimately hasn't actually changed, though? Maybe it was just one particular device manufacturer messing about with things?

Certainly for me v2.0 works on a Sony Xperia 10 V running Android 14, whereas v3.0 fails (because FolderRestrictionhookA14 throws a NoSuchMethodError exception which isn't caught, and therefore stops the subsequent old FolderRestrictionhook from executing).

DanGLES3 commented 6 months ago

FolderRestrictionhookA14

K, I'm looking into it asap

DanGLES3 commented 6 months ago

Sorry for the trouble

DanGLES3 commented 6 months ago

According to the source code, the method name ultimately hasn't actually changed, though? Maybe it was just one particular device manufacturer messing about with things?

Certainly for me v2.0 works on a Sony Xperia 10 V running Android 14, whereas v3.0 fails (because FolderRestrictionhookA14 throws a NoSuchMethodError exception which isn't caught, and therefore stops the subsequent old FolderRestrictionhook from executing).

Is your Xperia on Android 14 QPR2? I suspect that change was made there

buttercookie42 commented 6 months ago

Ah right, I didn't get the significance of the QPR. I suppose it isn't. But it means in any case the new hook needs wrapping inside of a try/catch or some other check whether the old or new hook is required.

DanGLES3 commented 6 months ago

Ah right, I didn't get the significance of the QPR. I suppose it isn't. But it means in any case the new hook needs wrapping inside of a try/catch or some other check whether the old or new hook is required.

Alright, i'm working on it rn, it may take awhile but i'll do what i can

DanGLES3 commented 6 months ago

Ah right, I didn't get the significance of the QPR. I suppose it isn't. But it means in any case the new hook needs wrapping inside of a try/catch or some other check whether the old or new hook is required.

app-release.zip

This should solve the issue

DanGLES3 commented 6 months ago

Ah right, I didn't get the significance of the QPR. I suppose it isn't. But it means in any case the new hook needs wrapping inside of a try/catch or some other check whether the old or new hook is required.

main.zip

And here's the source code if you want to check if it's okay, i've tested on my end just to make sure it works

DanGLES3 commented 6 months ago

Ah right, I didn't get the significance of the QPR. I suppose it isn't. But it means in any case the new hook needs wrapping inside of a try/catch or some other check whether the old or new hook is required.

And sorry for taking so long, i'm not exactly much of programmer

buttercookie42 commented 6 months ago

Thanks a lot and no worries, I knew how to work around that issue (and in any case my phone decided to suddenly refuse accessing most of the internal storage, so I had to wipe and re-install it anyway).