search

Xpra-org / xpra-html5

HTML5 client for Xpra
Mozilla Public License 2.0
192 stars 53 forks source link

JavaScript exception in HTML5 client version 11.1 'Uncaught TypeError: self.set_encoding_option is not a function' #294

Closed jeffmax closed 4 months ago

jeffmax commented 4 months ago

Describe the bug JavaScript exception in client.js when offscreen_api is true.

To Reproduce Using a browser with offscreen_api available, connect to server using HTML5 11.1 client

System Information (please complete the following information):

Additional context I think this line mistakenly uses self instead of this: https://github.com/Xpra-org/xpra-html5/blob/master/html5/js/Client.js#L547

jeffmax commented 4 months ago

Apologies, I meant to open this in the xpra-html5 repo.

totaam commented 4 months ago

Thanks for the report. The issue has been moved to xpra-html5. This was caused by a buggy PR: #288

The commit above fixes it.