search

Xpra-org / xpra-html5

HTML5 client for Xpra
Mozilla Public License 2.0
209 stars 55 forks source link

restoring tab does not prompt for authentication #308

Closed totaam closed 4 months ago

totaam commented 4 months ago 
xpra start --bind-tcp=0.0.0.0:10000,auth=sys --no-daemon  --start=xterm :6

Connecting with Google Chrome:

sending hello
using new navigator.clipboard
clipboard polling:  true
no clipboard write support: no images, navigator.clipboard= Clipboard {}
sending hello capabilities {version: '13', client_type: 'HTML5', display: '', build: {…}, platform: {…}, …}
process challenge: xor

Then I enter my password and authentication proceeds:

challenge using salt digest hmac+sha512
hmac using hash sha512
challenge using digest xor
sending hello

If I close the tab then open a new one going to the same address, the password dialog pops up again. But if I restore the tab, then chrome does something else and the password prompt does not show up. Eventually the connection fails and the connect page shows up, connecting from there does show the password prompt again.

I can make it easier to debug by hitting reload whilst the password dialog is showing. This seems to trigger the same problem, without closing the javascript console.

totaam commented 4 months ago

The clue was here in the console: using password = [object HTMLInputElement] from parameters

Fixed in 6209443c3a99fc29709ea98eb4646aa834794d95