search

Xpra-org / xpra-html5

HTML5 client for Xpra
Mozilla Public License 2.0
209 stars 55 forks source link

xpra-html5 and xpra deploy same files in share/xpra/www #310

Closed gl-yziquel closed 3 months ago

gl-yziquel commented 3 months ago

Having been attempting to build and install purely from source, I noticed that the xpra package deploys some but not all files in share/xpra/www and that xpra, via ./setup.py install, installs kind of a superset.

They kind of step upon one another.

This induces problems in my personal build and packaging system as installing xpra and then xpra-html5 cannot be expected to produce the same results as installing xpra-html5 and then xpra. This lack of commutativity of installation sequence induces a lack of stability and reproducibility in deployment.

totaam commented 3 months ago

Please be specific.

gl-yziquel commented 3 months ago

Specific ? In what sense ?

What I see, for instance, is that both an installation of xpra and an installation of xpra.html each deploy a version of the connect.html file.

totaam commented 3 months ago

No, they do not.

totaam commented 3 months ago

See https://github.com/Xpra-org/xpra/wiki/Reporting-Bugs And also the note about distribution packages.

gl-yziquel commented 3 months ago

Yes. They do. I am not using distribution packages. I am trying to find custom homegrown stable installation of xpra from pure source. It's me going around your build system trying to get xpra install in my .pyenvs.

I'm using commands like:

./setup.py install /home/mini-me/.pyenv/versions/3.12.2/ /share/xpra/www

And I do notice quite a lot of inconsistencies.

For instance:

'./setup.py install /home/yziquel/.pyenv/versions/3.12.2/' attempts to install in /home/yziquel/.pyenv/versions/3.12.2/home/yziquel/.pyenv/versions/3.12.2/share/xpra/www with duplicated prefix.

Now, you may say "this is not the way I support things", which is perfectly OK. Saying "you don't see what you see" is not quite the same thing...

For instance, this duplicate path prefix issue is tied to suboptimal handling of paths in setup.py. I consider that a bug.

totaam commented 3 months ago

The HTML5 client is not a python project and knows nothing about python.

The xpra package does not include any html pages.

gl-yziquel commented 3 months ago

I rechecked. Indeed. Scratching everything up and rebuilding and reinstalling xpra from scratch does not give me a share/xpra folder anymore. It is thus extremely unclear to me why I had a connect.html file there before having dabbled with xpra-html5.

Thank you. Will look at how to make my build from source + deployment procedures more robust.

gl-yziquel commented 3 months ago

Wow !! Now works !!! Virtualised OSX on KVM viewable via xpra just rocks ! Thank you so much !