search

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.91k stars 164 forks source link

Compiling --without-vpx still pulls in vpx functionality #1270

Closed totaam closed 8 years ago

totaam commented 8 years ago

Issue migrated from trac ticket # 1270

component: core | priority: major | resolution: invalid

2016-07-30 10:51:05: caspercg created the issue

I'm compiling xpra 0.17.4 on Ubuntu 14.04 from source with --without-vpx, but the vpx libraries are still being pulled in.

This produces a crash on 14.04 in reference to:
https://www.xpra.org/trac/ticket/1084

Therefore it's impossible to get xpra 0.17.4 to run on 14.04.

0.16.0 (previous version I compiled) worked fine with --without-vpx, and the vpx initialization was skipped properly.

Not sure why --without-vpx is not working. The first time I compiled it I forgot to use --without-vpx. I then installed it and realized the mistake. I ran ./setup.py clean and recompiled with --without-vpx.

I tried rm -rf build also before recompiling and installing, but makes no difference.

Why is --without-vpx not working, and how do I disable it in 0.17.4?

Where in the code are the vpx libraries being initialized. Is there something I can comment out manually?

Thank you.

totaam commented 8 years ago

2016-07-30 11:14:34: caspercg commented

Manually commenting out all references to vpx in xpra/codecs/loader.py disabled vpx properly.

totaam commented 8 years ago

2016-07-30 14:57:54: caspercg changed status from new to closed

totaam commented 8 years ago

2016-07-30 14:57:54: caspercg set resolution to worksforme

totaam commented 8 years ago

2016-07-30 16:41:08: antoine changed status from closed to reopened

totaam commented 8 years ago

2016-07-30 16:41:08: antoine removed resolution (was worksforme)

totaam commented 8 years ago

2016-07-30 16:41:08: antoine commented

No. This change is definitely NOT correct. Do not do this. Anyone reading this ticket should not follow these instructions.

You must have had some old build laying around. Make sure you clear everything before you install again and you will not have vpx included, and it will not be found:

rm -fr build dist/ install
./setup.py install --without-vpx --home=./install
find install/ -name "*vpx*"
PYTHONPATH=./install/lib64/python python ./install/lib64/python/xpra/codecs/loader.py
totaam commented 8 years ago

2016-07-30 16:41:41: antoine changed status from reopened to closed

totaam commented 8 years ago

2016-07-30 16:41:41: antoine set resolution to invalid

totaam commented 8 years ago

2016-07-30 16:41:41: antoine commented

--without-vpx works as expected, as shown in comment:3.