Closed totaam closed 8 years ago
This looks identical to r12391. Can you run this without crashing:
$ python -c "import netifaces;print(netifaces.gateways())"
If not, then this is a netifaces bug. (what version do you have installed?)
Oh, and I believe this ticket has nothing to do with the client connecting: you should be able to cause the crash just by running "xpra info" on the server. (which will also query the gateways)
We can apply this to xpra to skip netifaces, as we already do on OSX:
--- xpra/net/net_util.py (revision 13361) +++ xpra/net/net_util.py (working copy) @@ -34,8 +34,8 @@ def get_gateways(): if not has_netifaces: return {} - #no idea why, but this causes crashes on OSX: - if sys.platform.startswith("darwin"): + #no idea why, but this causes crashes on OSX and FreeBSD: + if sys.platform.startswith("darwin") or sys.platform.startswith("freebsd"): return {} try: d = netifaces.gateways()
Tested on freebsd 10.3 and netifaces is completely broken there and crashes as soon as you call it.
This is a freebsd bug, r13420 (same as the patch above) just skips netifaces on freebsd.
You are correct. Applying your patch to 0.17.4 does in fact resolve the issue.
I'll open a bug with FreeBSD. Thanks you for testing on your end.
Thank you very much for fixing.
For reference, I am adding a link to the following ticket, which indicates that this is fixed in a certain version of python and netifaces: https://bitbucket.org/al45tair/netifaces/issues/15/gateways-function-crash-segmentation-fault
I don't see in that upstream ticket which change fixed the crash so I've changed our code in r13468 to disable the call to
netifaces.gateways()
unless the netifaces version is 0.10.5 or later - which I have tested on OSX. netifaces version bump for rpms (pushed to stable repo) and osx builds in r13467.
Issue migrated from trac ticket # 1288
component: server | priority: major | resolution: fixed
2016-08-21 15:01:31: akadanitan created the issue