Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
2k stars 171 forks source link

Paint issues using scrolling encoding #1352

Closed totaam closed 8 years ago

totaam commented 8 years ago

Issue migrated from trac ticket # 1352

component: android | priority: major | resolution: duplicate

2016-11-07 21:02:20: maxmylyn created the issue


Okay, so I'm seeing some some widespread yet intermittent issues using the scrolling codec (hmmm maybe we should come up with a cool name).

For now I'm using a Fedora 24 trunk 1.0 r14398 server and client

For the most part the following websites are the easiest to trigger:

  • Craigslist

  • Wikipedia

  • Trac

  • Reddit (specifically /r/AskReddit threads)

Basically any site that has a good mix of text yet interactive fields causes some weird behavior. I see everything from double lines of text to images appearing over comment fields (if the image is behind a collapsible element). I also see behavior similar to the b-frames issue of the application updating but not getting the paint.

And, to make it more annoyoing, it's most prevalent in Fedora, and every time I try to open Ksnap it gets a paint refresh and goes away.

Turning on XPRA_OPENGL_PAINT_BOX I see that it occurs when there's a mix of the scrolling codec, png, and rgb24 (orange).

Repro steps are spotty, I'm trying to narrow down a valid and reliable repro but am coming up with nothing:

  • Start an Xpra session
  • Open Firefox
  • Navigate to one of the problem sites and interact with it as normal
  • Intermittent scrolling and typing will cause some weird and broken paints periodically - I see something on average once every 5 minutes or so.
    • Using reddit comment sections and making them collapse and uncollapse triggers the broken paints far more often.

I'm not entirely sure what -d flag to use - is there one specific to the scrolling codec?

totaam commented 8 years ago

2016-11-07 21:04:19: maxmylyn uploaded file 1352 paint bug.png (508.9 KiB)

for anyone who is browsing with a small child overlooking their shoulder, some language in the attached file. 1352 paint bug.png

totaam commented 8 years ago

2016-11-07 21:07:08: maxmylyn commented


Re that attachment:

I use the RES extension which allows the browser to open the image through the link in the comment. I opened the image and then collapsed it, and it painted over the comment.

totaam commented 8 years ago

2016-11-09 08:26:06: antoine changed owner from antoine to maxmylyn

totaam commented 8 years ago

2016-11-09 08:26:06: antoine commented


Please add information to #1232 and close this one.

Please try with b-frames disabled, and include the "-d scroll,compress" log output of around the time of the display issue. It would also help to have a screenshot of the problem to go with the log sample, and also a screenshot of the picture once it is fixed (minimizing then restoring the window should do it)

totaam commented 8 years ago

2016-11-11 18:45:44: maxmylyn commented


Still an issue with B-Frames disabled, however I'm finding it much harder to get the paint bug to "stick". For now it seems to be breaking slightly and then it clears itself up. Of course the one time I did get it to stick, telling kscreenshot to take a screenshot did a full refresh and it went away. Figures.

Will re-enable B-Frames and try to get the logs for you.

totaam commented 8 years ago

2016-11-11 18:56:42: maxmylyn commented


Got new screenshots for you - unfortunately the -d compress,scroll didn't seem to actually print anything into the log file - will have to restart session with --no-daemon and just pipe that into a log file.

totaam commented 8 years ago

2016-11-11 18:58:17: maxmylyn uploaded file 1352 paint bug broken.png (355.5 KiB)

Scrolling and collapsing comment sections 1352 paint bug broken.png

totaam commented 8 years ago

2016-11-11 18:58:40: maxmylyn uploaded file 1352 paint bug refreshed\ .png (354.7 KiB)

minimize and maximize Firefox - it went away 1352 paint bug refreshed\ .png

totaam commented 8 years ago

2016-11-11 19:07:32: maxmylyn uploaded file 1352dscrollcompress.txt (1039.3 KiB)

Managed to get a similar repro to the other two screenshots - let it sit for a sec, then minimized and maximized Firefox

totaam commented 8 years ago

2016-11-11 21:10:52: maxmylyn changed owner from maxmylyn to antoine

totaam commented 8 years ago

2016-11-11 21:10:52: maxmylyn commented


Passing back to you - this last round was done with a trunk r14404 Fedora 24 server and client.

totaam commented 8 years ago

2016-11-11 21:20:46: maxmylyn changed status from new to closed

totaam commented 8 years ago

2016-11-11 21:20:46: maxmylyn set resolution to duplicate

totaam commented 8 years ago

2016-11-11 21:20:46: maxmylyn commented


Okay I re-read comment:2

Closing this one.