search

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.91k stars 164 forks source link

Incorrect icon paths in Window.js #1903

Closed totaam closed 6 years ago

totaam commented 6 years ago

Issue migrated from trac ticket # 1903

component: html5 | priority: major | resolution: fixed

2018-07-05 12:47:32: berserker created the issue

I was told that this issue is already fixed mainstream (https://github.com/totaam/xpra-html5/pull/1#issuecomment-402606387), but I still see '../icons/' instead of just 'icons/' in the Trunk:

                                  '<span id="maximize' + String(wid) + '"><img src="../icons/maximize.png" /></span> '+
                                  '<span id="close' + String(wid) + '"><img src="../icons/close.png" /></span> '+
totaam commented 6 years ago

Sorry, I misread the patch. We changed to use relative urls to handle non-standard paths. I don't understand why relative paths would not work here. Can you provide a sample configuration?

totaam commented 6 years ago

2018-07-05 14:08:37: berserker commented

Replying to [comment:1 Antoine Martin]:

We changed to use relative urls to handle non-standard paths. I don't understand why relative paths would not work here. Can you provide a sample configuration?

'icons/close.png' is also a relative path, it does not start with /. I'm trying to run Xpra behind the Jupyter single-user server with its nbserverproxy extension, see https://github.com/jupyterhub/nbserverproxy/issues/35. This is a sample configuration. Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

totaam commented 6 years ago

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

That's exactly it. Thanks for bearing with me, applied in r19846.

totaam commented 6 years ago

2018-07-05 23:45:13: berserker commented

Replying to [comment:4 Antoine Martin]:

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files. That's exactly it. Thanks for bearing with me, applied in r19846.

When it will appear in the Bionic beta repository?

totaam commented 6 years ago

When it will appear in the Bionic beta repository?

Try now.