search

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.98k stars 169 forks source link

cannot concatenate 'str' and 'memoryview' objects #2334

Closed totaam closed 5 years ago

totaam commented 5 years ago

Issue migrated from trac ticket # 2334

component: network | priority: major | resolution: fixed

2019-06-16 00:20:29: berserker created the issue

xpra GTK2 X11 version 2.5-[r22138](../commit/71c84797503c7cba94e1d06fd54aaf5109770964) 64-bit
 running with pid 1 on Linux CentOS Linux 7.6.1810 Core
HTML5 Posix Firefox client version 3.0

(Note that I'm using HTML5 client version 3.0 with Xpra version 2.5)

2019-06-15 23:10:43,923 Error: read on ws socket: 127.0.0.1:8080 <- 127.0.0.1:33300 failed: <type 'exceptions.TypeError'>
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 638, in _io_thread_loop
    while not self._closed and callback():
  File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 717, in _read
    self._process_read(buf)
  File "/usr/lib64/python2.7/site-packages/xpra/net/websockets/protocol.py", line 160, in parse_ws_frame
    self._process_ws_ping(full_payload)
  File "/usr/lib64/python2.7/site-packages/xpra/net/websockets/protocol.py", line 169, in _process_ws_ping
    item = encode_hybi_header(OPCODE_PONG, len(payload)) + payload
TypeError: cannot concatenate 'str' and 'memoryview' objects
2019-06-15 23:10:43,932 xpra client 1 disconnected.
totaam commented 5 years ago

2019-06-16 06:41:50: antoine changed status from assigned to closed

totaam commented 5 years ago

2019-06-16 06:41:50: antoine set resolution to fixed

totaam commented 5 years ago

2019-06-16 06:41:50: antoine commented

I'm not sure why I never hit this bug, strange. Trivial fix (you can apply it by hand) in r22961.