search

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.93k stars 165 forks source link

Missing xid arg in X11Window.MoveResizeWindow call #3909

Closed taranu closed 1 year ago

taranu commented 1 year ago

Describe the bug xpra client fails to connect to server, which then writes Python errors to the log.

System Information (please complete the following information):

Additional context The following line appears to be missing an xid as the first arg, and was causing clients to fail to connect and raising errors in the server (that only 4 positional args were provided instead of the required 5):

https://github.com/Xpra-org/xpra/blob/a6dfd3e116280e39c1e8de1bffe7585df4660c1f/xpra/x11/models/window.py#L272

I tried changing it to X11Window.MoveResizeWindow(self.corral_xid, nx, ny, w, h) and that seems to work. I'm just not 100% sure if it should be self.xid instead.

totaam commented 1 year ago

Just as you suggested, 1840e4164b243274bec9f6763a130933e5c64e91 should fix this.

Xpra Server Version: 5.0-r33125

Are you sure that this is the version you are using? This beta would be many months old. Is so, please try a more recent build.