Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.98k stars 169 forks source link

shadow: Maximizing a 1920x1200 on a 1920x1080 display creates "weird artifacts" #4116

Closed stdedos closed 4 months ago

stdedos commented 9 months ago

Describe the bug

image

I understand the window doesn't fit vertically. But it looks downright ugly for no reason (it's not that "somehow" it fits looking like this)

"Xpra-x86_64_6.0-r35043\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --headerbar=off --source-start=gnome-keyring-daemon --title="@title@ on @@/@server-display@" --encodings=-webp --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=\$! ; xpra xwait ; kill -9 \$inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --microphone=off --speaker=off --webcam=no --pulseaudio=no --opengl=no --min-speed=70 --key-shortcut=Shift+F2:toggle_pointer_grab

XPRA_EXECUTABLE=Xpra-x86_64_6.0-r35043

2024-01-31 22:41:10,110 Xpra GTK3 client version 6.0-r35043 (g48292788a) beta
2024-01-31 22:41:10,120  running on Microsoft Windows
2024-01-31 22:41:10,120  cpython 3.11
2024-01-31 22:41:10,566 GStreamer version 1.22.9
2024-01-31 22:41:10,575 created named pipe 'Xpra\25184'
2024-01-31 22:41:10,733 Error setting up the pipeline:
2024-01-31 22:41:10,733  gst_parse_error: could not link decoder to sink (3)
2024-01-31 22:41:10,733  GStreamer pipeline for:
2024-01-31 22:41:10,733   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2024-01-31 22:41:10,733   d3d11h264dec name=decoder ! \
2024-01-31 22:41:10,733   appsink name=sink emit-signals=1 max-buffers=10 drop=False sync=False async=True qos=False caps=video/x-raw,width=128,height=128,format=(string)I420
2024-01-31 22:41:10,734 Error creating context h264 128x128 YUV420P
2024-01-31 22:41:10,734 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2024-01-31 22:41:10,739 keyboard layout 'United States - English' : 'us' (0x409)
2024-01-31 22:41:10,806  keyboard settings: layout=us
2024-01-31 22:41:10,809  desktop size is 4480x1516:
2024-01-31 22:41:10,810   Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2024-01-31 22:41:10,810     Samsung C32JG5x  2560x1440 at    0x0    (697x392 mm - DPI: 93x93) workarea: 2560x1400
2024-01-31 22:41:10,811     LG IPS234        1920x1080 at 2560x436  (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2024-01-31 22:41:30,944 enabled remote logging
2024-01-31 22:41:30,946 Xpra shadow server version 5.0
2024-01-31 22:41:30,947  remote desktop size is 1920x1200
2024-01-31 22:41:30,947   :1.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at   72x27
2024-01-31 22:41:30,948     LGD eDP-1        (336x210 mm - DPI: 145x145)
2024-01-31 22:41:31,280 running, 1 windows

(xpra_cmd:25184): Pango-WARNING **: 22:41:32.680: couldn't load font "Petyka - Retro Computer___SHORT Not-Rotated 17.98828125", falling back to "Sans Not-Rotated 17.98828125", expect ugly output.

(xpra_cmd:25184): Pango-WARNING **: 22:41:32.719: couldn't load font "DejaVu Serif Not-Rotated 59.796875", falling back to "Sans Not-Rotated 59.796875", expect ugly output.

(xpra_cmd:25184): Pango-WARNING **: 22:41:32.728: couldn't load font "URW Bookman L Not-Rotated 52.76171875", falling back to "Sans Not-Rotated 52.76171875", expect ugly output.
2024-01-31 22:49:44,509 window 1 has been moved to monitor 1: LG IPS234 1920x1080 at 2560,436
2024-01-31 22:49:50,867 window 1 has been moved to monitor 0: Samsung C32JG5x 2560x1440 at 0,0
2024-01-31 22:49:55,868 window 1 has been moved to monitor 1: LG IPS234 1920x1080 at 2560,436

To Reproduce Steps to reproduce the behavior:

  1. server command
  2. client command
  3. specific action to trigger the bug

System Information (please complete the following information):

Additional context Add any other context about the problem here. Please see "reporting bugs" in the wiki section.

stdedos commented 9 months ago

Trying to click with the mouse, or selecting text fixes this

image

but scrolling breaks it again

image

totaam commented 9 months ago

Can you please include some server -d compress log events from the problematic updates? (and xpra info)

My guess is that some of these screen updates are scaled and some are not. The window should be using a fixed size, even if that means not fitting on screen, so there should be no scaling involved.

stdedos commented 4 months ago

It seems to not be replicating

XPRA_EXECUTABLE=Xpra-Light-x86_64_6.1-r35982
XPRA_FILE_CHOOSER_NATIVE=2

2024-06-26 23:13:08,345 Xpra GTK3 client version 6.1-r35982 (gc1ebe16a5b) beta (light build)
2024-06-26 23:13:08,534  running on Microsoft Windows Microsoft Windows 10 Enterprise
2024-06-26 23:13:08,534  cpython 3.11
2024-06-26 23:13:08,886 GStreamer version 1.24.4
2024-06-26 23:13:08,894 created named pipe 'Xpra\39004'
2024-06-26 23:13:08,938 keyboard layout 'United States - English' : 'us' (0x409)
2024-06-26 23:13:08,967 Connected (version 2.0, client OpenSSH_8.2p1)
2024-06-26 23:13:09,080 SSH password authentication failed:
2024-06-26 23:13:09,080  Bad authentication type
2024-06-26 23:13:09,081   allowed types: ['publickey', 'password']
2024-06-26 23:13:13,721 Authentication (password) successful!
2024-06-26 23:13:13,925 ssh server OS is 'linux-gnu'
2024-06-26 23:13:14,082 paramiko SSH agent forwarding enabled
2024-06-26 23:13:14,139  keyboard settings: layout=us
2024-06-26 23:13:14,141  desktop size is 4480x1516:
2024-06-26 23:13:14,141   Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2024-06-26 23:13:14,142     Samsung C32JG5x  2560x1440 at    0x0    (697x392 mm - DPI: 93x93) workarea: 2560x1400
2024-06-26 23:13:14,142     LG IPS234        1920x1080 at 2560x436  (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2024-06-26 23:13:14,203  SSH: 'found existing display 0 : LIVE'
2024-06-26 23:13:14,417 enabled remote logging
2024-06-26 23:13:14,420 Xpra shadow server version 5.0
2024-06-26 23:13:14,421  remote desktop size is 1920x1200
2024-06-26 23:13:14,421   :0.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at   72x27
2024-06-26 23:13:14,422     LGD eDP-1        (336x210 mm - DPI: 145x145)