Closed stdedos closed 6 months ago
E:/xpra/xpra/client/gtk3/client_base.py:618: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "title" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
E:/xpra/xpra/client/gtk3/client_base.py:618: PyGTKDeprecationWarning: The "buttons" argument must be a Gtk.ButtonsType enum value. Please use the "add_buttons" method for adding buttons. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:566: PyGTKDeprecationWarning: The keyword(s) "parent" have been deprecated in favor of "transient_for" respectively. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
Thanks. All of these warnings are fixed in the commit above.
As for all the GLib-GIO-CRITICAL **: 20:55:38.879: file ../glib-2.80.0/gio/gfileinfo.c: line 1610 (g_file_info_get_file_type): should not be reached
, I cannot reproduce the problem.
My guess is that this is: Check for attribute availability before accessing it which has been fixed in GTK. Perhaps the version of GTK in your builds is older than mine?
Can you try with 6.1-r35715
or later?
Perhaps the version of GTK in your builds is older than mine?
WDYM? I haven't installed any GTK by myself. ... the only GTK-thing I have installed is "C:\Program Files (x86)\GtkSharp\2.12\", via Pinta
I just downloaded https://www.xpra.org/beta/windows/Xpra-Light-x86_64_6.1-r35715.zip
Clicking to upload the file gives:
"Xpra-x86_64_6.0-r35620\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --headerbar=off --title="@title@ on @@/@server-display@" --encodings=-webp --microphone=off --speaker=off --webcam=no --pulseaudio=no --opengl=no --min-speed=70 --key-shortcut=Shift+F2:toggle_pointer_grab
XPRA_EXECUTABLE=Xpra-x86_64_6.0-r35620
2024-05-04 12:06:54,323 Xpra GTK3 client version 6.0-r35620 (g79036646b) beta
2024-05-04 12:06:54,563 running on Microsoft Windows Microsoft Windows 10 Enterprise
2024-05-04 12:06:54,563 cpython 3.11
2024-05-04 12:06:55,064 GStreamer version 1.24.1
2024-05-04 12:06:55,081 created named pipe 'Xpra\26052'
2024-05-04 12:06:55,258 Error setting up the pipeline:
2024-05-04 12:06:55,259 gst_parse_error: could not link decoder to sink (3)
2024-05-04 12:06:55,259 GStreamer pipeline for:
2024-05-04 12:06:55,259 appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2024-05-04 12:06:55,259 d3d11h264dec name=decoder ! \
2024-05-04 12:06:55,259 appsink name=sink emit-signals=1 max-buffers=10 drop=False sync=False async=True qos=False caps=video/x-raw,width=128,height=128,format=(string)I420
2024-05-04 12:06:55,260 Error creating context h264 128x128 YUV420P
2024-05-04 12:06:55,260 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2024-05-04 12:06:55,265 keyboard layout 'United States - English' : 'us' (0x409)
2024-05-04 12:06:55,359 keyboard settings: layout=us
2024-05-04 12:06:55,361 desktop size is 4480x1516:
2024-05-04 12:06:55,361 Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2024-05-04 12:06:55,361 Samsung C32JG5x 2560x1440 at 0x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400
2024-05-04 12:06:55,361 LG IPS234 1920x1080 at 2560x436 (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2024-05-04 12:06:59,812 enabled remote logging
2024-05-04 12:06:59,814 Xpra shadow server version 5.0
2024-05-04 12:06:59,814 remote desktop size is 1920x1200
2024-05-04 12:06:59,815 :1.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at 72x27
2024-05-04 12:06:59,815 LGD eDP-1 (336x210 mm - DPI: 145x145)
2024-05-04 12:07:00,182 running, 1 windows
E:/xpra/xpra/client/gtk3/client_base.py:618: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "title" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
E:/xpra/xpra/client/gtk3/client_base.py:618: PyGTKDeprecationWarning: The "buttons" argument must be a Gtk.ButtonsType enum value. Please use the "add_buttons" method for adding buttons. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:566: PyGTKDeprecationWarning: The keyword(s) "parent" have been deprecated in favor of "transient_for" respectively. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
2024-05-04 12:08:41,841 UI thread is now blocked
(xpra_cmd:26052): Gtk-WARNING **: 12:08:41.939: Could not find the icon 'bookmark-new-symbolic-ltr'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
http://icon-theme.freedesktop.org/releases
2024-05-04 12:08:41,957 UI thread is running again, resuming
but uploading the file (shuffling gifs etc) works as normal.
If "somehow" you could fix that the "E:\path\to\file.txt"
would work similarly to E:\path\to\file.txt
, that'd be great š
WDYM? I haven't installed any GTK by myself.
I wasn't saying you did! Every win32 build is going to have whatever updates were available in the MSYS2 rolling distribution. Which means that even on the same day, you may get two different GTK versions in 2 different builds...
PyGTKDeprecationWarning: Using positional arguments ...
Well, that's weird!
1ec038bf9a8ca398fd74016a7acf4ebfce5c1942 definitely removes parent
and uses add_buttons
instead of the constructor.
And now I see:
Xpra GTK3 client version 6.0-r35620 (g79036646b) beta
Which is older than the r35715 required.
If "somehow" you could fix that the "E:\path\to\file.txt" would work similarly to E:\path\to\file.txt, that'd be great š
I have no idea what this is about! :shrug:
And now I see:
Xpra GTK3 client version 6.0-r35620 (g79036646b) beta
Which is older than the r35715 required.
Daaaaamn. ... forgot to save the variable change š
If "somehow" you could fix that the "E:\path\to\file.txt" would work similarly to E:\path\to\file.txt, that'd be great š
I have no idea what this is about! š¤·
If you have the Upload window open, you are able to "paste" the path on the Upload window to paste it on the location
and then you don't have to locate the file locally.
However, that doesn't work if the path is double-quoted
PyGTKDeprecationWarning: Using positional arguments ...
Well, that's weird! 1ec038b definitely removes
parent
and usesadd_buttons
instead of the constructor. And now I see:
Xpra GTK3 client version 6.0-r35620 (g79036646b) beta
Which is older than the r35715 required.
You are right. It's fixed š š š
However, that doesn't work if the path is double-quoted
Ah, gotcha. This is a GTK widget and we have no control over these implementation details. Feel free to file a bug upstream.
Apparently, we're supposed to use FileChooserNative on win32 and macos: fec4bb7e410c490753c9433acae2870f639f6525
Please try 6.1-r35733
or later.
Apparently, we're supposed to use FileChooserNative on win32 and macos: fec4bb7
No self.file_dialog.add_buttons(*buttons)
?
No
self.file_dialog.add_buttons(*buttons)
?
Nope, not supported. Why?
Just checking. It is "slight" deviation of your current experience (default action was "Open").
... tbh, I do prefer the upload function to upload, instead of open
Well, there is a set_accept_label function. We could set it to "Upload" - that should work.
I am starting to prefer the old non-native chooser: at least it lets you choose between "upload" and "upload then open". The native one does not.
I am starting to prefer the old non-native chooser: at least it lets you choose between "upload" and "upload then open". The native one does not.
Yeah, that's what I meant:
Just checking. It is "slight" deviation of your current experience (default action was "Open").
But also
... tbh, I do prefer the upload function to upload, instead of open
Probably you could do it with checkboxes, but I do agree nothing beats a "Upload / Open (remote) / Cancel" combo from a functionality standpoint. ... and nothing beats native look & feel either :sweat_smile:
Partially reverted: c594c346db9ad6037576b8e8c3b2a0bfcfbe0376
... so, FILE_CHOOSER_NATIVE=2
does my stuff :upside_down_face: :heart:
Partially reverted: c594c34
Do you mind swapping the options?
Response Codes Gtk.FileChooserNative inherits from Gtk.NativeDialog, which means it will return Gtk.ResponseType.ACCEPT if the user accepted, ...
In your code:
Which means that the dialog sends ACCEPT
, but that executes a different action from the "Upload" label the button has
Sorry, I have no idea what you want me to do. You know you can just edit the file here: https://github.com/Xpra-org/xpra/blob/526c6a81925f3e21fbad5221d984e683214b409f/xpra/client/gtk3/client_base.py#L612-L613
Describe the bug A clear and concise description of what the bug is.
I was shadowing, Shuffing Gifs at Slack, and uploaded a file (tried to "auto-find" it by pasting its quoted path inside the file-picker window; didn't work).
To Reproduce Steps to reproduce the behavior:
System Information (please complete the following information):
Additional context Add any other context about the problem here. Please see "reporting bugs" in the wiki section.