search

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.98k stars 169 forks source link

make it possible to completely disable all of GStreamer at runtime #4330

Closed totaam closed 3 months ago

totaam commented 3 months ago

Using #4307 to completely prevent gi.repository.Gst bindings from being loaded.

That's necessary because GStreamer can cause some serious problems. Latest case in point: Linux Mint 22 in VirtualBox, loading GStreamer kills the X11 server!

totaam commented 3 months ago

Done in the commit above. ie:

xpra start --no-gstreamer

This is also activated with --minimal=yes (#3953)

totaam commented 2 months ago

Very useful since there are some monsters lurking - I'm not blaming GStreamer, hardware access is hard, and crashy.

Running Linux Mint 22 in VirtualBox, simply probing the gstreamer elements from xpra causes the whole desktop session to crash and go back to the login screen!

janLo commented 1 month ago

FYI: the death of the X-Server only happens if the gstreamer1.0-vaapi package is installed.

totaam commented 1 month ago

@janLo this should probably be reported as security issue somewhere, though I doubt that anyone cares. Hardware access is hard.

Meanwhile, I can't think of anything xpra can do here - vaapi is what we need for hardware acceleration on non-nvidia GPUs, so we're caught in a bind.

janLo commented 1 month ago

Oh, thank you, I, personally, don't really need a solution, I just wanted to note that it's not necessary to disable all of gstreamer if the Xorg crash happens.

We discovered this already a year ago. Our solution is to blacklist the package where we can and have it very prominently written in our internal documentation for everyone else coming across this.