too many keyboard error messages

Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.

https://xpra.org/

GNU General Public License v2.0

1.98k stars 169 forks source link

too many keyboard error messages #4337

Closed totaam closed 2 months ago

totaam commented 2 months ago

About a dozen of these:

Error: no keycodes found for keysym 'Alt_R' (65514)

Are printed for every connection coming from a client without a full x11 keymap.. (ie: MS Windows clients)

Caused by this commit: c6a040f7b6bee296e9576c7b2e8b20dbe153ee8e Which has already been backported and released in older branches.. (ie: 6.1.1)

totaam commented 2 months ago

I think the fix is correct. TBH, this code has grown so complex that I can't be certain. But at least the warnings are gone and we have more modifiers available, which should help in triggering some special keysyms.