python3 and gtk3 support

totaam commented 12 years ago

Issue migrated from trac ticket # 90

component: core | priority: major | resolution: fixed

2012-03-27 08:53:09: antoine created the issue

Makes sense to bundle this together since python3 is only really supported with gtk3 and vice versa.

Main work items:

backwards compatible python3 changes (via 2to3 mostly), most already done in r618, r619, r620, r621 and r622

python3 strings: changes need testing on python2.5, also need to ensure that calling encode(..) and decode(..) does not adversely affect performance

for other non-backwards compatible python3 changes, find a way to run 2to3 during build so we can keep a unified source tree in python2 format. (main issue here: catch exception syntax change)

gtk3 imports have moved and now require annotation to silence pydev lint

gtk3 methods on gtk.Window have changed, client.py will need to provide wrapper methods:

gdk.get_default_root_window().get_pointer() (removed)

gdk.get_default_root_window().get_size() (removed)

gtk.Window.__init__(win, wintype) (removed: no arg constructor now)

window.set_geometry_hints(...) (signature changed)

window.flags() (removed - must call get_$FLAGNAME)

window.window.set_cursor(..) (renamed to window.override_cursor?)

window.window.invalidate_rect (now window.queue_draw_area)

do_expose_event(event) is now do_draw(context)

window.window.get_geometry (removed, must now call get_position() and get_size()?)

constants have moved

gdk.keymap_get_default (removed?)

gdk.Cursor can no longer use pixbuf..

...

gtk3 removed GdkPixmap and GdkImage, we're supposed to be using cairo but cairo.ImageSurface.create_for_data is not implemented in pycairo and there are no alternatives (ouch!)

PIL (Python Imaging Library) is not available on python3 (so we can't use that to fix cairo either)

totaam commented 12 years ago

2012-03-27 12:32:55: antoine changed status from new to accepted

totaam commented 12 years ago

2012-03-27 12:32:55: antoine commented

More done in r626, r627, r628, r629 and r630: most of the code is now python3/gtk3 compatible, except for:

client.py (large changes due to cairo brokenness)

protocol.py (string encoding changes - painful as this as repercussions elsewhere)

totaam commented 12 years ago

2012-03-27 20:10:02: antoine commented

Some useful links:

GObject Introspection

Introspection Porting

Migrating from GTK+ 2.x to GTK+ 3 (and in particular changes that need to be done at the time of the switch)

GTK+ 3 Reference Manual

The Python GTK+ 3 Tutorial

Converting PIL Image to GTK Pixbuf

pygi-convert.sh

Ubuntu app indicators when using PyGObject (grrr)

Convert PIL Image to Cairo ImageSurface

PIL and Cairographics / PyCairo

cairo.ImageSurface.create_for_data

totaam commented 12 years ago

2012-03-27 20:10:02: antoine

totaam commented 12 years ago

2012-03-27 20:10:02: antoine

totaam commented 12 years ago

2012-03-28 08:50:54: antoine uploaded file `xpra-gtk3.patch` (33.0 KiB)

rough patch for gtk3/python3 support

totaam commented 12 years ago

2012-03-28 08:58:18: antoine commented

The patch above "works" in the sense that one can get something on screen with gtk3, but it has a number of important shortcomings:

problems with the new StringIO class, which fails because of a missing fileno()

jpeg and rgb24 have to be parsed using PIL then exported to PNG to then be loaded by cairo as cairo is incapable of loading anything else (seriously!? gtk devs, this is not an upgrade by a giant leap backwards). For rgb24 it seems to require an unnecessarily large rowstride (RGBA? according to this answer it uses 32 bit per channel data no matter what) - which we do not control as it is generated by gdk on the server side. This means making png the default and finding a solution for the mmap case: possibly using cairo server side to export with the rowstride expected by cairo on the client? Maybe also moving the draw/expose code to a utility class so we can use the current code on gtk2 and the new horrible mess on gtk3 only.

some re-drawing problems due to coordinates and clipping interfering with each other (shouldn't be too hard to fix)

totaam commented 12 years ago

2012-03-28 08:58:18: antoine

totaam commented 12 years ago

2012-03-28 18:31:06: antoine commented

r640 makes python3 + gtk3 almost usable by providing two different window backing mechanisms (we keep the old/fast code for gtk2, cairo for gtk3). But there are still many issues remaining:

most of the gtk3 function stubs at the top of client.py are still missing an actual implementation (no cursors, no keyboard support, etc)

display = gdk.display_get_default() and watching for screen changes has been hacked out with a if not is_gtk3() guard

the gtk3 version of the tray menu is mostly broken due to api changes: missing icons, about dialog errors, etc

totaam commented 12 years ago

2012-03-28 18:31:06: antoine

totaam commented 12 years ago

2012-03-30 13:44:20: antoine commented

r654 fixes the about dialog

r653 fixes the session info dialog

totaam commented 12 years ago

2012-03-30 15:48:45: antoine commented

r667 fixes get_modifiers_mask, set_geometry_hints and is_flag_set vs MAPPED/REALIZED

totaam commented 12 years ago

2012-04-04 07:10:08: antoine commented

There are serious compatibility issues between the new io.StringIO module and PIL, r697 reverts back to StringIO.StringIO in order to fix window icons - this will cause problems when trying to port the server to gtk3/python3.

totaam commented 12 years ago

2012-05-04 10:48:56: antoine

totaam commented 12 years ago

2012-05-04 10:48:56: antoine commented

delayed, this is hard!

totaam commented 11 years ago

2012-09-27 16:23:25: antoine

totaam commented 11 years ago

2013-07-16 07:10:28: antoine changed status from accepted to new

totaam commented 11 years ago

2013-07-16 07:10:28: antoine

totaam commented 11 years ago

2013-07-16 07:10:28: antoine commented

Worth updating and getting the basics to work properly (keyboard, etc)

And maybe also: transparency, GL, cursors, ..

totaam commented 11 years ago