search

XpressAI / SparkCyclone

Plugin to accelerate Spark SQL with the NEC Vector Engine.
https://sparkcyclone.io
Apache License 2.0
16 stars 4 forks source link

[NS-44] Vectorize Merge #585

Closed treo closed 2 years ago

treo commented 2 years ago

From #584, which unfortunately started from an unclean state:

Fix for NS-44 (Replace bitwise merge with vectorized merge):

nullable_scalar_vector and nullable_varchar_vector now use cyclone_utils::fast_validity_merge for vectorized merge of validity bits.

I'd love to know, if it's any faster now...

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

treo commented 2 years ago

This will need a slight update when https://github.com/XpressAI/SparkCyclone/pull/586 is merged, as the append_bitsets signature is simpler now.