search

XrXr / YoutubeSubscriptionChecker

A Firefox add-on that checks for new uploads from Youtube channels
4 stars 0 forks source link

Unsafe way of getting channel title for notification #4

Closed XrXr closed 10 years ago

XrXr commented 10 years ago

In main.js the algorithm for getting the channel title relies on all channels being processed properly, which they might not. This will potentially cause incorrect channel title to be shown in notification

XrXr commented 10 years ago

Sometimes new uploads are added to the list but there is no notification nor button change. I haven't been able to locate the issue in the code, but its a minor issue since it will be detected in the next cycle. I suspect the issue has something to do with this issue.

XrXr commented 10 years ago

5bc541ead4f174177c51c0d5608e67f550f9d88f should have fixed the issue. Tests were done by randomly rejecting promises