Xruptor / BagSync

BagSync tracks your characters items and displays it within tooltips.
http://www.wowinterface.com/downloads/info15351-BagSync.html
Other
32 stars 21 forks source link

Emblem counts in WOTLK #320

Closed sam-k-taylor closed 10 months ago

sam-k-taylor commented 10 months ago

Would be nice to see the number of emblems, Scourgestones ect... across characters on tooltip

Xruptor commented 10 months ago

If it's a currency, you should be able to see your characters and totals in the currency window of BagSync. Currency and Items are treated differently by the WOW client. That's why it's separated.

Xruptor commented 10 months ago

Whoops closed it by accident LOL.

sam-k-taylor commented 10 months ago

Currency window is empty on WotLK classic

image

Tracking enabled

image

Xruptor commented 10 months ago

That's really odd? Perhaps the currency is broken in the WOTLK client or it's treated differently? I recall it working before. I'd have to look into it.

sam-k-taylor commented 10 months ago

if you need me to test anything to get this working i can do

sam-k-taylor commented 10 months ago

@Xruptor any update?

Xruptor commented 10 months ago

@Xruptor any update?

I've been worked up in stuff at the moment. I hadn't had a chance to pop in the PTR version of WOTLK to check. Mmm perhaps I have some time in the afternoon to quickly hop on and see what's going on.

Xruptor commented 10 months ago

Just to make sure you are referring to these right? @sam-k-taylor https://www.wowhead.com/wotlk/item=12841/invaders-scourgestone https://www.wowhead.com/wotlk/item=12841/invaders-scourgestone

and these right? https://www.wowhead.com/wotlk/currency=102/emblem-of-valor

for the stones, note they are items that go in your inventory and not the currency window of your character. That's probably why they aren't showing. They are treated as items rather then actual (game coded) currency. I'd have to review that.

In terms of the emblems if they ARE showing in the in game currency window for Blizzards stuff, then it should be counting them in BagSync. I'd have to see a screenshot of your in game currency window (the blizzard one, not the BagSync one).

Xruptor commented 10 months ago

Okay so I was able to do the stuff that is considered currency. But the items that go into your inventory or bags, really aren't considered "currency" in the code itself. It's just regular items that you stack up to turn in. These types of items ARE counted in BagSync, just not in the Currency window. You can do a search for them and view the tooltip there in BagSync for those.

sam-k-taylor commented 9 months ago

@Xruptor these https://www.wowhead.com/wotlk/currency=2711/defilers-scourgestone

sam-k-taylor commented 9 months ago

image Legend