search

Xruptor / BagSync

BagSync tracks your characters items and displays it within tooltips.
http://www.wowinterface.com/downloads/info15351-BagSync.html
Other
32 stars 21 forks source link

[Bug?] Duplicate currencies in module if you change client language #328

Closed zeenk closed 7 months ago

zeenk commented 7 months ago

Yesterday I was testing loading up my wow client in german just to see if my weakaura I made was working for other languages and today when I was gonna check currencies in BagSync I noticed some had duplicated with the german name, is it possible to get rid of them or should I just do a savedvariable wipe on my account? 😂

2024-03-18_23-36-19

Xruptor commented 7 months ago

The only way that can happen is if for SOME reason Blizzard decided to use different currencyID's for various languages. I'd have to check but this isn't a bug that would normally happen unless you specifically changed languages. Meaning it's not something you see everyday or would affect that many people. I'd need a look at your BagSync.lua file from WTF/SavedVariables folder to determine that.

zeenk commented 7 months ago

The currency id is the same for both but I'm guessing since the german name is different it then created a new line instead of just replacing the previous name

So yeah just gonna remove my SV file and re-load my characters, seems to be the easiest solution, not many people gonna run into this issue😛

If you want to test with different languages yourself you can just press the cogwheel next to play button and change language here under game settings 2024-03-19_23-08-21

zeenk commented 7 months ago

Oh right.. I found why it was doing this, it was because I have not logged in on every alt yet with the different language client so the addon was still storing the english names as well on some alts, but after I logged in on all alts with german client then all english names were gone, so you can ignore this. sorry :)

Xruptor commented 7 months ago

Oh right.. I found why it was doing this, it was because I have not logged in on every alt yet with the different language client so the addon was still storing the english names as well on some alts, but after I logged in on all alts with german client then all english names were gone, so you can ignore this. sorry :)

Are you sure though? I could always look at the code and just add some sort of check not to duplicate based on CurrencyID.

zeenk commented 7 months ago

Sure, if you have a quick fix for it then go ahead and add it :)

Xruptor commented 7 months ago

Sure, if you have a quick fix for it then go ahead and add it :)

I'll just add a redundancy check to make sure it doesn't repeat the currencies.