search

Xruptor / BagSync

BagSync tracks your characters items and displays it within tooltips.
http://www.wowinterface.com/downloads/info15351-BagSync.html
Other
32 stars 21 forks source link

freez when riding race quest start and complete #350

Closed Darksky1991 closed 1 month ago

Darksky1991 commented 1 month ago

as title described, when i start and complete a riding race world quest, the whole graphic freeze 1-2s for start, and 5-10s for complete. and i checked that when only BagSync loaded, it's not changed. obviously it should be the BaySync's problem i think.

Darksky1991 commented 1 month ago

i don't know why, maybe not only bagsync, i found that elvui and altoholic has same situation. trying to scan and repaire game and reinstall single addon and check again

repaired the game and no change

NDui(which is similar with elvui) no problem

nanjuekaien1 commented 1 month ago

Delete WTF BagSync.lua and BagSync.lua.bak.

Darksky1991 commented 1 month ago

i have tried to delete all the WTF, Interface, Cache, Logs, Fonts folders and repaired the game and reset all the setting in game, then just installed the bagsync, but no effect

Xruptor commented 1 month ago

If other addons are causing the issue it may be something else entirely. What happens when you have NO addons loaded at all? Does the issue still occur?

Xruptor commented 1 month ago

In addition you stated that even with BagSync disabled the issue still happens with other addons (ElviUI and Altoholic). So technically this isn't a BagSync bug. The only thing I can recommend is disabling all addons and enabling them one at a time to see which is causing the problem. Otherwise it may be something with your game client, graphics drivers or something PC related.

Darksky1991 commented 1 month ago

as i commented before,

Darksky1991 commented 1 month ago

In addition you stated that even with BagSync disabled the issue still happens with other addons (ElviUI and Altoholic). So technically this isn't a BagSync bug. The only thing I can recommend is disabling all addons and enabling them one at a time to see which is causing the problem. Otherwise it may be something with your game client, graphics drivers or something PC related.

maybe some lib goes weird?

nanjuekaien1 commented 1 month ago

This happened to me on Mar 14, 2024 when I was also using NDui, then I deleted the WTF BagSync.lua and BagSync.lua.bak from WTF and I have not had any problems since.

Darksky1991 commented 1 month ago

This happened to me on Mar 14, 2024 when I was also using NDui, then I deleted the WTF BagSync.lua and BagSync.lua.bak from WTF and I have not had any problems since.

thank you. I just tried again, no improve. but I found anothing thing, when I just checked the Currency module, freez will happen. Others are OK. just uncheck the currency module for the moment

Xruptor commented 1 month ago

In addition you stated that even with BagSync disabled the issue still happens with other addons (ElviUI and Altoholic). So technically this isn't a BagSync bug. The only thing I can recommend is disabling all addons and enabling them one at a time to see which is causing the problem. Otherwise it may be something with your game client, graphics drivers or something PC related.

maybe some lib goes weird?

It's possible that it could be a library that all of the addons share. I'm not exactly sure as I'd have to do a comparison.

This happened to me on Mar 14, 2024 when I was also using NDui, then I deleted the WTF BagSync.lua and BagSync.lua.bak from WTF and I have not had any problems since.

thank you. I just tried again, no improve. but I found anothing thing, when I just checked the Currency module, freez will happen. Others are OK. just uncheck the currency module for the moment

This doesn't explain why it happens with the other addons though. Perhaps its an issue associated with currency as the other addons also do handle stuff with currency. Have you tried unchecking everything and ONLY keeping Currency enabled? Does the issue still happen?

I'll review the code but it's somewhat hard to fix if I can't reproduce the issue myself. Lets do some investigation work :)

Darksky1991 commented 1 month ago

Have you tried unchecking everything and ONLY keeping Currency enabled? Does the issue still happen?

yes, I have compared only currency be checked and non checked. I attached the BagSync's debug log below, but it looks goes well. race-complete-ng-currency-nocache.txt race-complete-ok-nocurrency-nocache.txt race-start-ng-currency-nocache.txt race-start-ok-nocurrency-nocache.txt

And, internal event trace log as below the NG case have a event spent 3-4s, but it's not constant, some time PLAYER_STOPPED_TURNING event, some time SPELL_ACTIVATION_OVERLAY_HIDE event. race complete NG complete-ng-onlycurrency

race complete OK complete-ok-noaddon

Xruptor commented 1 month ago

WOW..... CURRENCY_DISPLAY_UPDATE is being spammed by blizzards servers! No wonder you are getting lag. I mean look at how much within the same second. That's insanity... That has to be the issue as your currencies are being scanned by all the addons each time.

Xruptor commented 1 month ago

Out of curiosity, try this version of BagSync. Let me know if that stops the issue? All I did was add a spam protection buffer for CURRENCY_DISPLAY_UPDATE.

BagSync.zip

Darksky1991 commented 1 month ago

Out of curiosity, try this version of BagSync. Let me know if that stops the issue? All I did was add a spam protection buffer for CURRENCY_DISPLAY_UPDATE.

it was fixed!! You're so greateful^_^ Maybe China's server just back not for long and not stable, and should be fixed in the future.

Xruptor commented 1 month ago

Out of curiosity, try this version of BagSync. Let me know if that stops the issue? All I did was add a spam protection buffer for CURRENCY_DISPLAY_UPDATE.

it was fixed!! You're so greateful^_^ Maybe China's server just back not for long and not stable, and should be fixed in the future.

It definitely has to be the server as nobody else has mentioned this issue. The only thing I can assume is that it's a bug on their end for spamming CURRENCY_DISPLAY_UPDATE that much. I'll just add the spam check for everyone in case this happens again.