search

Xruptor / LagBar

Displays a simple bar with some Latency Information.
http://www.wowinterface.com/downloads/info12373-LagBar.html
5 stars 2 forks source link

Added a config option to disable the hover tooltip. #8

Closed draknyte1 closed 3 years ago

draknyte1 commented 3 years ago

As described in title. Hover text annoys me (Probably others) and is redundant once you've placed it somewhere permanately or have used the addon for a while.

Xruptor commented 3 years ago

Thank you for the addition! I didn't think that the tooltip was bothering folks, but I'm glad you added the option for others.

draknyte1 commented 3 years ago

I do hope the PR was upto par as my LUA knowledge is rather rubbish. Luckily the existing code was very easy to follow.

Did try to make the tooltip display regardless of the config value if shift was held, but I didn't want to do two separate if checks doubling up on code and felt putting the tooltip code into a new function was a tad overkill. Couldn't figure out how to do a if (config || (!config & shift.isHeld())), so I just kept it rather simple!

Xruptor commented 3 years ago

Actually it works out pretty well just do enable or disable it. That way you wouldn't need to hold shift. Thanks again for your contribution!