search

Xtendify / Simple-Calendar

Add Google Calendar events to your WordPress site.
https://simplecalendar.io
GNU General Public License v2.0
46 stars 37 forks source link

Calendar Start Date Issue in Grid View #567

Open Akhill2020 opened 2 weeks ago

Akhill2020 commented 2 weeks ago

Description: To resolve Calendar Start Date Issue in Grid View I have created new time format function which conert timstamp into readable time formate by using users timezone. Clickup: https://app.clickup.com/t/86cw8gbjx Before: https://prnt.sc/a0f46Hk5zcZ_ after: https://www.screenpresso.com/=qwxIb

rosinghal commented 2 weeks ago

@Akhill2020 https://github.com/Xtendify/Simple-Calendar/pull/565 has the same changes. How to review this?

Akhill2020 commented 2 weeks ago

@Akhill2020 #565 has the same changes. How to review this?

in PR 565 I was pushed changes by mistake that branch can be close, we have already released that changes. So I have created this new PR. I will push all the feedback given there in this PR and will close that PR.

What is the diff between date_i18n and $this->format_timestamp?

in date_i18n it does not give preference to timezone if we pass a timestamp in it, and in the format_timestamp function, we format the date by using timezone.

Is this condition correct !empty($simple_calendar_auth_site_token && $is_authhelper)? Why two conditions inside empty?

Yes, it is checking for both variables; both should have value.

What's the diff between admin_init and init?

admin_init will work only in admin and init is work on both admin and on front end page load.