search

Xtra-Computing / thundergbm

ThunderGBM: Fast GBDTs and Random Forests on GPUs
Apache License 2.0
689 stars 85 forks source link

No TGBMClassifier and TGBMRegressor in Windows version of thundergbm_scikit.py #27

Closed canasta closed 4 years ago

canasta commented 4 years ago

I installed thundergbm via pip install thundergbm-cu10-0.2.0-py3-none-win_amd64.whl which is described in quick install of README.rd. There are no TGBMClassifier and TGBMRegressor in thundergbm_scikit.py, but only TGBMModel. I think you'd better to make these two classes in thundergbm_scikit.py or rewrite how-to-use.

Kurt-Liuhf commented 4 years ago

Thanks for the comments. We have updated the '.whl' file now. You can reinstall thundergbm via pip install thundergbm-0.3.4-py3-win64.whl, which is described in the quick install of README.md. Also, I suggest that you should read the documentation of how-to.md, which would help you understand how to build your own .whl file.

canasta commented 4 years ago

Thanks for updating. But I think the name new file is wrong. I'm not familiar about wheel files, so I don't know exactly whether it is wrong or not, but according to PEP 491, The wheel filename must be like {distribution}-{version}(-{build tag})?-{python tag}-{abi tag}-{platform tag}.whl. So the name of uploaded wheel file has to be changed like thundergbm-0.3.4-py3-none-win_amd64.whl.