Require cmake minimum version 3.4 on all platforms

Xtra-Computing / thundersvm

ThunderSVM: A Fast SVM Library on GPUs and CPUs

Apache License 2.0

1.55k stars 215 forks source link

Require cmake minimum version 3.4 on all platforms #200

Closed emmenlau closed 4 years ago

emmenlau commented 4 years ago

This PR updates the minimum required cmake to 3.4 on all platforms. Older cmake can be causing some problems without proper setting of cmake policies. For example, on macOS the variables CMAKE_C_COMPILER_ID and CMAKE_CXX_COMPILER_ID are set to Clang instead of AppleClang.

There are also a few minor whitespace changes for readability.

Closes #198

zeyiwen commented 4 years ago

Thanks. PR #201 will need some tests, and will be merged when the tests are done.