search

Xtra-Computing / thundersvm

ThunderSVM: A Fast SVM Library on GPUs and CPUs
Apache License 2.0
1.55k stars 215 forks source link

Generalize OpenMP requirement on all platforms #201

Closed emmenlau closed 4 years ago

emmenlau commented 4 years ago

I'm under the impression that OpenMP is a general requirement because it is used not only in the Eigen kernels but also in some of the tools. This PR makes OpenMP a general requirement and ensures all libraries and tools are linked against OpenMP.

This PR also helped me to enable OpenMP support on macOS. With PR #200 and this PR merged, I only have to specify -DOpenMP_C_INCLUDE_DIRS=... and -DOpenMP_CXX_INCLUDE_DIRS=... to the path of omp.h. No other settings are required, OpenMP is successfully detected.

Please test and let me know what you think?

emmenlau commented 4 years ago

Thanks @zeyiwen for looking into this. I hope its generally fine, but let me know if I misunderstood something about OpenMP...

shijiashuai commented 4 years ago

looks good to me

emmenlau commented 4 years ago

Thanks!