Use cmake option() for setting external parameters

Xtra-Computing / thundersvm

ThunderSVM: A Fast SVM Library on GPUs and CPUs

Apache License 2.0

1.55k stars 215 forks source link

Use cmake option() for setting external parameters #202

Closed emmenlau closed 4 years ago

emmenlau commented 4 years ago

This PR replaces the use of set() with option() to make sure users get the typical cmake behavior for setting external parameters. Additionally, this PR adds a default for cmake setting BUILD_SHARED_LIBS to ensure users build a shared library as before, as requested in #197

zeyiwen commented 4 years ago

Thanks @emmenlau

emmenlau commented 4 years ago

Glad that you like it! Keep up the good work!