Enable logging for C API when not in quiet mode

Xtra-Computing / thundersvm

ThunderSVM: A Fast SVM Library on GPUs and CPUs

Apache License 2.0

1.55k stars 215 forks source link

Enable logging for C API when not in quiet mode #237

Closed ankane closed 3 years ago

ankane commented 3 years ago

Hi, thanks for this library!

When running thundersvm_train or thundersvm_train_after_parse multiple times in the same C program, logging is disabled for the remainder of the program if one of the calls uses quiet mode. This PR resets logging for each call so calls that don't use the -q option have logging.

zeyiwen commented 3 years ago

Thanks @ankane The PR looks good to me. We will double-check and merge the PR.

ankane commented 3 years ago

Thanks @zeyiwen. It looks like CI is failing for Mac since Homebrew no longer supports macOS 10.13. Adding osx_image: xcode10.2 or higher to the Travis config should fix it (I can include it in the PR if you want).

zeyiwen commented 3 years ago

Sure thing @ankane. Please help update the Travis config.

ankane commented 3 years ago

Thanks @zeyiwen and @Kurt-Liuhf