Xubuntu / xubuntu-default-settings

Default settings for the Xubuntu desktop
https://launchpad.net/ubuntu/+source/xubuntu-default-settings
44 stars 8 forks source link

LP#1991389 "Selecting "Install Xubuntu 22.10" icon results in error message" #57

Closed github-actions[bot] closed 6 months ago

github-actions[bot] commented 2 years ago

Reported first on Launchpad at https://bugs.launchpad.net/ubuntu/+source/xubuntu-default-settings/+bug/1991389

github-actions[bot] commented 2 years ago

LP#0: Leó Kolbeinsson (leok) wrote on 2022-09-30:

Testing Xubuntu Kinetic beta 20220927.1 in Live session

After booting up Live session and selecting "Try Xubuntu" proceeded to desktop and the selected the desktop icon "Install Xubuntu 22.10 this resulted in the following error dialog box (see attached screenshot)

"The desktop file "ubiquity-desktop" is in an insecure location and not marked as executable."

The user is presented with 3 choices

  1. launch anyway 2.mark as executable 3.cancel

ProblemType: Bug DistroRelease: Ubuntu 22.10 Package: xubuntu-default-settings 22.10.1 ProcVersionSignature: Ubuntu 5.19.0-15.15-generic 5.19.0 Uname: Linux 5.19.0-15-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.23.0-0ubuntu2 Architecture: amd64 CasperMD5CheckResult: pass CasperVersion: 1.475 CurrentDesktop: XFCE Date: Fri Sep 30 10:24:10 2022 LiveMediaBuild: Xubuntu 22.10 "Kinetic Kudu" - Beta amd64 (20220927.1) PackageArchitecture: all ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: xubuntu-default-settings UpgradeStatus: No upgrade log present (probably fresh install)

github-actions[bot] commented 2 years ago

LP#1: Leó Kolbeinsson (leok) wrote on 2022-09-30:

Attachments:

github-actions[bot] commented 2 years ago

LP#2: Ubuntu QA Website (ubuntuqa) wrote on 2022-09-30:

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here: https://iso.qa.ubuntu.com/qatracker/reports/bugs/1991389

newhoa commented 1 year ago

The solution to make the launcher trusted via command line is here but I don't know how to implement it for the LiveCD.

The solution is, aside from needing to be marked as an executable (chmod +x), that a metadata entry needs to be added via gio for xfce-exe-checksum with the checksum:

f=FILE; gio set -t string $f metadata::xfce-exe-checksum "$(sha256sum $f | awk '{print $1}')"

Which will result (running gio info FILE) with something like this:

metadata::xfce-exe-checksum: ab38b223e98fe8f2a28q2a11167d7c9c671096c4a7c5e495c9594f3ee75dfd93
newhoa commented 7 months ago

Edit: Made an error here, will repost in a minute. Sorry!

newhoa commented 7 months ago

Ok, this should set the desktop icon to trusted and avoid the error. It should also update the icon on both the desktop and Settings Manager to use the new ubiquity icon in the elementary-xfce-icon-theme. Hope I did it okay, feel free to change the in-file descriptions and formatting or whatever of course.

#!/bin/sh

# Use ubiquity icon for Desktop Launcher, set as trusted and mark as executable.

icon_name="ubiquity"
desktop_launcher="/home/xubuntu/Desktop/ubuntu-desktop-bootstrap_ubuntu-desktop-bootstrap.desktop"

desktop-file-edit --set-icon=$icon_name $desktop_launcher
gio set -t string $desktop_launcher metadata::xfce-exe-checksum "$(sha256sum $desktop_launcher | awk '{print $1}')"
chmod +x $desktop_launcher

# Settings Manager did not show changes when directly editing the snap launcher.
# So, copy the snap launcher to local apps, and update the icon on the local launcher.
# Settings Manager prefers the local .deskop file (if named the same), so this should replace the snap one.

snap_launcher="/var/lib/snapd/desktop/applications/ubuntu-desktop-bootstrap_ubuntu-desktop-bootstrap.desktop"
settings_launcher="/home/xubuntu/.local/share/applications/ubuntu-desktop-bootstrap_ubuntu-desktop-bootstrap.desktop"

mkdir "/home/xubuntu/.local/share/applications/"
cp $snap_launcher $settings_launcher
desktop-file-edit --set-icon=$icon_name $settings_launcher

Only issue with changing the icon is some themes might not provide it (Adwaita doesn't) so if a user tries out themes during the live trial and then goes back to install, the icon may be generic/missing. Maybe at some point the installer icon can be moved from elementary-xfce to the xubuntu-default-settings or wherever (and uniquely named) so that it always stays the same no matter which theme is chosen.

newhoa commented 6 months ago

@bluesabre This issue (and the icon issue) were resolved, so I think this issue can be closed.

Launcher untrusted error fixed in casper: https://git.launchpad.net/ubuntu/+source/casper/commit/?id=e910c2777d9ecfa5d100111b3e5d2b0cd149b081

Icon reverted back to ubiquity name in Bootstrap installer launcher: https://github.com/canonical/ubuntu-desktop-provision/commit/15db38972b9d647000f3f50d169b2830c556b8b7

bluesabre commented 6 months ago

Good stuff. Closing out!