search

Xubuntu / xubuntu-default-settings

Default settings for the Xubuntu desktop
https://launchpad.net/ubuntu/+source/xubuntu-default-settings
44 stars 8 forks source link

Remove "Sound" .desktop file #66

Closed newhoa closed 1 year ago

newhoa commented 1 year ago

It seems that a while back a Xubuntu custom launcher for pavucontrol was added because at the time pavucontrol's own launcher didn't support Xfce Settings.

That support has since been added to pavucontrol.

This removes the Xubuntu-added Sound launcher so that two pavucontrol launchers aren't showing up in menus and Xfce Settings; only pavucontrol's own launcher should show now.

https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/42

I wasn't sure what to do about the .po files. I removed it from POTFILES.in and xds-desktop-files.pot, I would guess the .po files should update automatically or is there something I need to run?

Also, even though it's a fairly simple change, I don't really know how to test changes to xubuntu-default-settings without waiting for a commit and a xubuntu daily build. Any advice on this?

Thanks.

bluesabre commented 1 year ago

This looks good to me. At some point I should add package building to the CI to make changes easier to test. Once this is merged, Transifex should pick up on it and update all of the .po files.

ochosi commented 1 year ago

This looks good to me. At some point I should add package building to the CI to make changes easier to test. Once this is merged, Transifex should pick up on it and update all of the .po files.

@bluesabre CI already builds the theme and keeps an archive around for every run/PR. As it's running on forks of the repo, you cannot easily post a comment to the PR with a link to that artifact.

You can go to the CI run though and grab the compiled theme for testing.