Chapter 6 - Githubissues

bluesabre commented 3 years ago

Cleanup and consolidation of previous attempts #14 #15 #16 #17

bluesabre commented 3 years ago

@JT252 Can you review and verify these are the changes you were going for?

@philipzae Since you're a bit more familiar with how we structure the docs now, can you review and confirm this looks good?

JT252 commented 3 years ago

Yes, but why are the corrections in the wording so different from what I'm transcribing in the gdoc?

Example;

old

new

John...

On Thu, Apr 15, 2021 at 6:29 AM Sean Davis @.***> wrote:

@JT252 https://github.com/JT252 Can you review and verify these are the changes you were going for?

@philipzae https://github.com/philipzae Since you're a bit more familiar with how we structure the docs now, can you review and confirm this looks good?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Xubuntu/xubuntu-docs/pull/19#issuecomment-820317265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQAC37X4CUL5H56RNRLSMO3TI25ZHANCNFSM426NCY6A .

bluesabre commented 3 years ago

@JT252 This is because the section ids have to be unique, not only on the individual file, but across multiple files. To achieve this, I chose a unique pattern that matched the sections and subsections. You can use the validate.sh script to quickly run validation before committing to make sure it checks out.

./scripts/validate.sh user-docs/C/settings-personalization.xml

JT252 commented 3 years ago

How would I have known this?

On Fri, Apr 16, 2021 at 5:25 AM Sean Davis @.***> wrote:

@JT252 https://github.com/JT252 This is because the section ids have to be unique, not only on the individual file, but across multiple files. To achieve this, I chose a unique pattern that matched the sections and subsections. You can use the validate.sh script to quickly run validation before committing to make sure it checks out.

./scripts/validate.sh user-docs/C/settings-personalization.xml

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Xubuntu/xubuntu-docs/pull/19#issuecomment-821045767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQAC37VSTPTFGNZ34D5DVLLTI767HANCNFSM426NCY6A .

JT252 commented 3 years ago

Also, when I tested the xml as described in this document: https://github.com/Xubuntu/xubuntu-docs/wiki after many modifications, the test passed and converted the file to a html file. When I run this file, I get a bunch of errors:

WTH??? 🤔

On Fri, Apr 16, 2021 at 5:25 AM Sean Davis @.***> wrote:

@JT252 https://github.com/JT252 This is because the section ids have to be unique, not only on the individual file, but across multiple files. To achieve this, I chose a unique pattern that matched the sections and subsections. You can use the validate.sh script to quickly run validation before committing to make sure it checks out.

./scripts/validate.sh user-docs/C/settings-personalization.xml

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Xubuntu/xubuntu-docs/pull/19#issuecomment-821045767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQAC37VSTPTFGNZ34D5DVLLTI767HANCNFSM426NCY6A .

philipzae commented 3 years ago

I have pending work on this chapter that I need to finalize and submit, so I think we can drop this MR.

bluesabre commented 3 years ago

I have pending work on this chapter that I need to finalize and submit, so I think we can drop this MR.

@philipzae Alrighty, will close it out. @JT252, please follow up with @philipzae to mak sure you're listed as a contributor on chapter 6.

Xubuntu / xubuntu-docs

Chapter 6 #19