search

Xudong-Huang / generator-rs

rust stackful generator library
Apache License 2.0
286 stars 35 forks source link

Compile failure on windows #19

Open carllerche opened 4 years ago

carllerche commented 4 years ago

For some reason, generator is starting to fail to compile on windows. This started recently on the Azure windows CI platform. Here is an example of a failed build:

https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=4652&view=logs&jobId=edbb8bb1-bc6c-5b89-6b1a-b043f7e49efc&j=edbb8bb1-bc6c-5b89-6b1a-b043f7e49efc&t=38b5b02f-30ce-5594-6cc9-d7432c882ad9

The error is:

error: failed to run custom build command for `generator v0.6.19`

Caused by:
  process didn't exit successfully: `D:\a\1\s\target\debug\build\generator-7edb320b2034b9ab\build-script-build` (exit code: 1)
--- stdout
TARGET = Some("i686-pc-windows-msvc")
running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x86\\ml.exe" "-safeseh" "-FoD:\\a\\1\\s\\target\\debug\\build\\generator-cb101e03a46c8720\\out\\src/detail/asm\\asm_i386_ms_pe_masm.o" "-c" "src/detail/asm\\asm_i386_ms_pe_masm.asm"
cargo:warning=Microsoft (R) Macro Assembler Version 14.16.27034.0
cargo:warning=Copyright (C) Microsoft Corporation.  All rights reserved.
cargo:warning=
 Assembling: src/detail/asm\asm_i386_ms_pe_masm.asm
MASM : fatal error A1000:cannot open file : src/detail/asm\asm_i386_ms_pe_masm.asm
exit code: 1

--- stderr

error occurred: Command "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x86\\ml.exe" "-safeseh" "-FoD:\\a\\1\\s\\target\\debug\\build\\generator-cb101e03a46c8720\\out\\src/detail/asm\\asm_i386_ms_pe_masm.o" "-c" "src/detail/asm\\asm_i386_ms_pe_masm.asm" with args "ml.exe" did not execute successfully (status code exit code: 1).
Xudong-Huang commented 4 years ago

Seems that the i686 target is not well supported. Is it possible to run the test on TARGET="x86_64-pc-windows-msvc"?

I will try to fix this for the i686 target.

carllerche commented 4 years ago

Thanks for the reply and I appreciate the work maintaining generator. It has been super useful for loom.

We have worked around by disabling our loom tests on windows, so we are not blocked :)