Xuerian / XLoot

World of Warcraft addon enhancing loot related functionality
Other
10 stars 1 forks source link

Icons not showing for loot and roll frames #17

Open stinkybagel opened 1 year ago

stinkybagel commented 1 year ago

Icons do not show correctly on either the loot frame or the roll frame. It instead shows a black box. wow-loot-frame-issue

Xuerian commented 1 year ago

Thanks for reporting this. I'm not sure what's causing it.

It looks like you're on classic, correct?

It's been reported here: https://www.wowace.com/projects/xloot/issues/212

But just like there, I don't have access to classic, and without errors or ideas I don't know what's going on. A cursory googling didn't show anything recent with GetLootSlotInfo not returning a working icon or anything related, and it seems to work on live, correct?

stinkybagel commented 1 year ago

Hello, thanks for the quick reply. Yes this is happening on Classic Era/SoM, game version 1.14.3. It seems to have happened with the recent WoW classic WoTLK Patch for Phase 2 Ulduar? That is when I noticed it has stopped working.

Oddly enough, I do not see this issue on WoW Classic WoTLK 3.4.1.

I am happy to try and run a debugger or some way to capture the errors. I am not too familiar with the preferred options to do so though. For now I will turn on lua errors on the console and see if I come across anything.

Xuerian commented 1 year ago

I have no idea what would be causing it. Thanks for trying to bisect.

The only thing I could suggest is opening XLoot Frame\Frame.lua and finding self.texture_item:SetTexture(slotData.icon) and adding xprint("%s texture: %s":format(slotData.name, slotData.icon)) before it.

Then /reload and show me what it says when it shows you blanks.

stinkybagel commented 1 year ago

Maybe I am dumb but do you mean like this? Because both of these throw a LUA error due to syntax.

Message: Interface\AddOns\XLoot_Frame\Frame.lua:693: ')' expected near ':' Time: Thu Feb 2 18:07:56 2023 Count: 2


692 -- Icon
693 xprint("%s texture: %s":format(slotData.name, slotData.icon))
694 self.texture_item:SetTexture(slotData.icon)

OR

692 -- Icon
693 xprint("%s texture: %s":format(slotData.name, slotData.icon))self.texture_item:SetTexture(slotData.icon)
Xuerian commented 1 year ago

The first one, but I gave you a typo anyway. xprint(("%s texture: %s"):format(slotData.name, slotData.icon)) should work

stinkybagel commented 1 year ago

Hello, that worked, thanks!

So I see no visual change in behavior.

Chat printed:
XLoot: 35 Copper texture: 133789 XLoot: Murloc Fin texture: 134304 wow-loot-frame-issue-after-change

Xuerian commented 1 year ago

It's the correct FileDataID as shown here

I don't know why it wouldn't work 😕 Thanks for checking. You can remove the line, not that you'd really want to use it while it's not showing you any icons anyway.

Given it works in the other versions, my only guess is it's some obtuse new wow bug. It sets the texture the same way the vanilla loot frame does.

stinkybagel commented 1 year ago

No worries, thank you also for trying some quick things. I saw a commenter on WoWAce mentioned the latest version of 9-xx was working, so I will try that as well.

stinkybagel commented 1 year ago

I can confirm that the 9.2.7-1 release is working. 9271-error-working

Xuerian commented 1 year ago

Interesting. Would you be willing to add the same line to that version and show me what it says? It should be the same, but I'd like to verify.

Also, can you confirm this is on an official classic server?

stinkybagel commented 1 year ago

Yes this server I am testing from is Shadowstrike, under the Seasonal Tab on WoW Classic from USA. I have another character on Whitemane, under the Classic Era tab from USA. Both exhibit the same issue with the 10-xx version.

stinkybagel commented 1 year ago

PFA print results in picture to confirm. Using 9.2.7-1 version, adding print line.

XLoot: 54 Copper texture: 133789 XLoot: Thick-shelled Clam texture: 134432 wow-loot-frame-issue--NEW-PRINT-97

stinkybagel commented 1 year ago

I also noticed the frame itself in 10-xx version is darker, is there a chance that something is obfuscating the window visually, rather than it being an icon/id failing to be pulled?

Xuerian commented 1 year ago

That seems likely to be related to the gradient changes between those two versions due to errors people were getting. It looks like it's less truly fixed, and more just quelled.

I'll look into that and report the texture issue. I see something similar in the WoWUI discord.

Xuerian commented 1 year ago

I also noticed the frame itself in 10-xx version is darker, is there a chance that something is obfuscating the window visually, rather than it being an icon/id failing to be pulled?

Would you be able to confirm if 10-x has the same black background/no gradient visual on other game versions for you?

stinkybagel commented 1 year ago

At the moment I do not have retail installed, but I was able to check WoW Classic WoTLK 3.4.1 on server Whitemane (US) using 10-xx, and it doesn't have the dark background/gradient issue. I'd assume retail has similar behavior to WoTLK and doesn't have the issue either in 10-xx.

Seems to be just be WoW Classic 1.14.3 SoM/Era servers affected by 10-xx.

wow-loot-frame-issue-wotlk-10x

Xuerian commented 1 year ago

I appreciate you checking those for me.

stinkybagel commented 1 year ago

No problem. Let me know if you need me to test anything else. For now, I'm using 9.2.7-1 on Classic Era content. Thanks