Xuerian / XLoot

World of Warcraft addon enhancing loot related functionality
Other
12 stars 2 forks source link

wowup integration #7

Closed YoanKECH closed 2 years ago

YoanKECH commented 2 years ago

Hello,

is that possible to fix it for wowup - git link ? At the moment reading 'assets' seems undefined

Thanks

Xuerian commented 2 years ago

I don't use WoWUp. Others who have requested it say it works after I updated the WoWI upload. Please confirm if you can switch sources or something and use that.

I keep hearing how bad CF is and how great wowup is but so far it's only caused me annoyance.

YoanKECH commented 2 years ago

when trying to integrate it says : Cannot read properties of undefined (reading 'assets')

lgrano commented 2 years ago

I understand your frustration with WoWUP, the situation with Overwolf/CF and WoWUP is unfortunately, WoWInterface download does work, the issue some people are having is that WoWI does not have good APIs to manage addons, for example WoWUP cannot search correctly from WoWI or figured out on its own when a addon such as XLoot support multiple clients on a single download.

A solution could be uploading your addon to Wago for example, that would fix all WoWUP issues. The reason people dont like CF anymore has to do with Overwolf, their client used to have a lot of adware and bloat as hidden install, personally id prefer to avoid installing anything that comes from that company on my pc.

Xuerian commented 2 years ago

I'd rather not go through submitting all the relevant information that Wago expects, I have similar feelings to that that apparently a large amount of people feel towards the curseforge client.

I've voluntarily used it to manage minecraft installs for a while.

If you've donated you're welcome to pursue this in an email with me.

notDavid commented 2 years ago

@Xuerian Could you consider putting the releases in https://github.com/Xuerian/XLoot/releases ?

At least that makes it easier to follow / get a Github notification when a new version is published :-) (via "Watch -> Custom -> Releases")

Xuerian commented 2 years ago

No, because despite common belief the curse forge packager actually does stuff.

Like packaging dependencies and translations from the translation platform.

Again, donators are welcome to pursue this via email if they desire.

On Wed, Jul 13, 2022 at 4:13 PM David @.***> wrote:

@Xuerian https://github.com/Xuerian Could you consider putting the releases in https://github.com/Xuerian/XLoot/releases ?

At least that makes it easier to follow / get a Github notification when a new version is published :-)

— Reply to this email directly, view it on GitHub https://github.com/Xuerian/XLoot/issues/7#issuecomment-1183633927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAXKJCROFETVB5FFRYUPTVT4PP3ANCNFSM5YHBYPCQ . You are receiving this because you were mentioned.Message ID: @.***>

YoanKECH commented 2 years ago

WOWI update has been made, agree to close. Solution Fixed