Xujiayao / Discord-MC-Chat

Discord-MC-Chat (DMCC), formerly known as MC-Discord-Chat and MCDiscordChat (MCDC), is a practical and powerful Fabric and Quilt Minecraft <> Discord chat bridge inspired by BRForgers/DisFabric
https://blog.xujiayao.com/posts/4ba0a17a/
MIT License
65 stars 36 forks source link

[Bug] After Updating from 2.1.4 to 2.2.0 the server did not start anymore #162

Closed suerion closed 1 year ago

suerion commented 1 year ago

Checks

Java Version

Java

Minecraft Version

1.19.2

MCDiscordChat Version

2.2.0

Description

I had updated only MCDiscordChat, tried also to recreate the Config, but don't work.

Server start not up

To Reproduce

Only Start server with 2.2.0, with 2.1.4 it work fine

Log

Here is the Full Log https://mclo.gs/PzdAnz0

Config

No config will created, but old Config on 2.1.4 work fine.

Xujiayao commented 1 year ago

Two options:

image

suerion commented 1 year ago

Then there is an issue on your side, because, on Curseforge and on Modrinth, the MCDiscord is shown for Compatibility on 1.19.2

grafik grafik

The apps are loading this as update for 1.19.2.

suerion commented 1 year ago

yet i know it is incompatible with 1.19.2 but other guys are not knowing.

Xujiayao commented 1 year ago

This is an expected problem, but I would not fix it because MCDC supported too many major and minor versions, and I do not want such unclean pages. If it bothered you, I would like to say sorry, but yeah, would not fix it.

image

Speak2Erase commented 1 year ago

I'm sorry, but this is not how you should be doing things. Lying about game version support just for the sake of cleanliness can (and did for me) cause headache for server owners. It's frankly bad software practice, just like breaking semver.

This is especially an issue as the mod will yell at you to update it, if you turned that on in the config. People need reminders to update things, and finding out that the update message they were getting spammed with for 2 days was wrong is a kick in the gut.

Xujiayao commented 1 year ago

@suerion @Speak2Erase @fortnider @thesabinelim I appreciate your desire to improve the mod for other players in the Minecraft community.

While it is important to ensure that the mod is compatible with the Minecraft versions it claims to support and to eliminate confusion and frustration for users, it is currently unrealistic to expect mod maintainers to test each MCDC release against every Minecraft minor version.

If you were to consider the suggestion to show the exact Minecraft versions supported by a new MCDC release in the future, you would realize that retroactively updating the version support information for all past releases would be demanding. This step is required to make such a suggestion effective, as it would result in incorrect information for previous versions if the potential problem is not fixed. MCDC has supported too many major and minor versions, that is the major problem here.

For example, let's say version 2.0.1 claims support for all versions from 1.14 to 1.19.1, but version 1.19 is not actually supported. If I select only [...] to 1.18.2, and 1.19.1, excluding 1.19, in the next version, 2.0.2, then the page would show that version 2.1.4 supports version 1.19, but this would be incorrect information.

However, I am unable to do all the demanding work myself and would appreciate any contribution you may have to this effort, given your eagerness to improve the mod for other players in the Minecraft community. Please note that I am busy in real life and would not be able to start fixing this demanding work until I find it possible to do so.

Thank you for bringing up your concerns and feedback. I hope you can contribute to MCDC practically to improve MCDC for the Minecraft community.

Speak2Erase commented 1 year ago

Can't you use GitHub actions to automate testing?

Xujiayao commented 1 year ago

No, these automated operations cannot be tested for compatibility and must be tested using server and client side manually. The behaviour of how each version of the mod is incompatible with a game varies from case to case. Some won't start the server at all, some can, but kick players out when they join a game, and some kick players out when they send chat messages, and even more.

Xujiayao commented 5 months ago

All issues re-examined:

Fixed in #180 already.