XuyangBai / D3Feat

[TensorFlow] Official implementation of CVPR'20 oral paper - D3Feat: Joint Learning of Dense Detection and Description of 3D Local Features https://arxiv.org/abs/2003.03164
MIT License
261 stars 38 forks source link

KITTI and 3DMatch, unalign or align? #29

Closed ZhengdiYu closed 3 years ago

ZhengdiYu commented 3 years ago

Hey Xuyang,

I noticed that you use unaligned point clouds for KITTI training and the aligned point clouds are only used as backup_points for computing the false negative mask, but when it comes to 3DMatch, you use aligned point clouds.

In an other issue you pointed out that you aligned the point clouds in 3DMatch and add rotation translation augmentation to achieve rotation invariance. Could I ask why there is a difference between 3DMatch and KITTI?

Best, Zhengdi

XuyangBai commented 3 years ago

Hi @ZhengdiYu it doesn't make much difference for using aligned or unaligned point cloud during training since we have rotation augmentation, you can also use unaligned point clouds for 3DMatch training.

Best, Xuyang.