Status line spammed and no git status icons when files or subdirectories have permission clash

[ebardie]

Self-Diagnosis

• [x] I have searched the issues for an answer to my question.
• [x] I have reviewed the NERDTree documentation(README.md).
• [x] I have searched the web for an answer to my question.

Environment (for bug reports)

• [x] Operating System: Linux / Debian

• [x] vimrc settings

  " all settings about nerdtree and other plugins

  let g:NERDTreeGitStatusUseNerdFonts = 1 
  
  set guifont=Hasklug\ Nerd\ Font\ Mono\ Semi-Bold
  
  augroup ProjectDrawer
  "  autocmd!
     " Fire up directory browser
  "  autocmd VimEnter * :Vexplore
      autocmd vimenter * NERDTree
  
      " Close window if NERDTree is the only thing open
      autocmd bufenter * if (winnr("$") == 1 && exists("b:NERDTree") && b:NERDTree.isTabTree()) | q | endif
  
      " Move focus to file
      autocmd VimEnter * wincmd p
  augroup END
  
  map <leader>nn :NERDTreeToggle<cr>
  map <leader>nb :NERDTreeFromBookmark
  map <leader>nf :NERDTreeFind<cr>

  • Other NERDTree-dependent Plugins
    • [ ] jistr/vim-nerdtree-tabs
    • [x] ryanoasis/vim-devicons
    • [ ] tiagofumo/vim-nerdtree-syntax-highlight
    • [ ] Others (specify): preservim/nerdtree
  • [] I've verified the issue occurs with only nerdtree-git-plugin installed

• [x] Copy-Paste call gitstatus#doctor#Say() outputs

  VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 12 2020 02:37:13)
  Included patches: 1-716
  Modified by team+vim@tracker.debian.org
  Compiled by team+vim@tracker.debian.org
  Huge version with GTK3 GUI.  Features included (+) or not (-):
  +acl               ++builtin_terms    +cmdline_info      +diff              -farsi             -hangul_input      +langmap           +mksession         +mouse_sgr         +num64             +profile           +signs             +tag_binary        +textobjects       +virtualedit       +writebackup +arabic            +byte_offset       +comments          +digraphs          +file_in_path      +iconv             +libcall           +modify_fname      -mouse_sysmouse    +packages          -python            +smartindent       -tag_old_static    +textprop          +visual            +X11 +autocmd           +channel           +conceal           +dnd               +find_in_path      +insert_expand     +linebreak         +mouse             +mouse_urxvt       +path_extra        +python3           +sound             -tag_any_white     +timers            +visualextra       -xfontset +autochdir         +cindent           +cryptv            -ebcdic            +float             +ipv6              +lispindent        +mouseshape        +mouse_xterm       +perl              +quickfix          +spell             +tcl               +title             +viminfo           +xim -autoservername    +clientserver      +cscope            +emacs_tags        +folding           +job               +listcmds          +mouse_dec         +multi_byte        +persistent_undo   +reltime           +startuptime       +termguicolors     +toolbar           +vreplace          +xpm +balloon_eval      +clipboard         +cursorbind        +eval              -footer            +jumplist          +localmap          +mouse_gpm         +multi_lang        +popupwin          +rightleft         +statusline        +terminal          +user_commands     +wildignore        +xsmp_interact +balloon_eval_term +cmdline_compl     +cursorshape       +ex_extra          +fork()            +keymap            +lua               -mouse_jsbterm     -mzscheme          +postscript        +ruby              -sun_workshop      +terminfo          +vartabs           +wildmenu          +xterm_clipboard +browse            +cmdline_hist      +dialog_con_gui    +extra_search      +gettext           +lambda            +menu              +mouse_netterm     +netbeans_intg     +printer           +scrollbind        +syntax            +termresponse      +vertsplit         +windows           -xterm_save
     system vimrc file: "$VIM/vimrc"
       user vimrc file: "$HOME/.vimrc"
   2nd user vimrc file: "~/.vim/vimrc"
        user exrc file: "$HOME/.exrc"
    system gvimrc file: "$VIM/gvimrc"
      user gvimrc file: "$HOME/.gvimrc"
  2nd user gvimrc file: "~/.vim/gvimrc"
         defaults file: "$VIMRUNTIME/defaults.vim"
      system menu file: "$VIMRUNTIME/menu.vim"
    fall-back for $VIM: "/usr/share/vim"
  Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-RuXSEA/vim-8.2.0716=. -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
  Linking: gcc   -L. -Wl,-z,relro -Wl,-z,now -fstack-protector-strong -rdynamic -Wl,-export-dynamic -Wl,-E  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim   -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux  -lcanberra -lacl -lattr -lgpm -ldl  -L/usr/lib -llua5.2 -Wl,-E  -fstack-protector-strong -L/usr/local/lib  -L/usr/lib/x86_64-linux-gnu/perl/5.30/CORE -lperl -ldl -lm -lpthread -lcrypt  -L/usr/lib/python3.8/config-3.8-x86_64-linux-gnu -lpython3.8 -lcrypt -lpthread -ldl -lutil -lm -lm -L/usr/lib/x86_64-linux-gnu -ltcl8.6 -ldl -lz -lpthread -lm -lruby-2.7 -lm
  ================================================================================
  NERDTree:
  version: 6.9.9
  root: /home/jonathansambrook/.vim/bundle/nerdtree-git-plugin
  ================================================================================
  Git:
  version: git version 2.28.0
  workdir: /home/jonathansambrook/.vim/bundle/nerdtree-git-plugin
  status output:
  ================================================================================
  Options:
  NERDTreeGitStatusShowIgnored = '0'
  NERDTreeGitStatusConcealBrackets = '0'
  NERDTreeGitStatusGitBinPath = 'git'
  NERDTreeGitStatusUseNerdFonts = 1
  NERDTreeGitStatusEnable = '1'
  NERDTreeGitStatusUpdateOnCursorHold = '1'
  NERDTreeGitStatusAlignIfConceal = '1'
  NERDTreeGitStatusLogLevel = '2'
  NERDTreeGitStatusShowClean = '0'
  NERDTreeGitStatusPorcelainVersion = '2'
  NERDTreeGitStatusMapPrevHunk = '[c'
  NERDTreeGitStatusUntrackedFilesMode = 'normal'
  NERDTreeGitStatusDirDirtyOnly = '1'
  NERDTreeGitStatusUpdateOnWrite = '1'
  NERDTreeGitStatusMapNextHunk = ']c'
  ================================================================================
  Others:
  vim-devicons: yes
  WebDevIconsNerdTreeGitPluginForceVAlign = 1
  WebDevIconsNerdTreeAfterGlyphPadding = ' '
  WebDevIconsNerdTreeBeforeGlyphPadding = ' '
  ----------------------------------------
  vim-nerdtree-syntax-highlight: no
  ----------------------------------------
  vim-nerdtree-tabs: no
  ================================================================================

  Steps to Reproduce the Issue

Unusual corner cases:

a) Run vim within a git controlled directory that has a directory which itself has subdirectories owned by a different user (in my case 'root') which the active user doesn't have permission to open.

    . - subdir - dir1
               - dir2
               - dir3
               - dir4
               - dir5
               - dir6
               - dir7
               - dir8

where `.` and `subdir` are owned by the active user and can be opened, and `dir1` through `dir8` are owned by another user and the active user doesn't have the permissions to open them.

or:

b) Run vim in a git controlled directory which contains a file owned by another user, and which the active user can't open.

I've come across situation (a) in the wild (hence this issue and associated PR) and constructed situation (b) when producing the proposed fix in the PR.

Current Result (Include screenshots where appropriate.)

Two problems ensue:

i) Vim's status is spammed with error reports:

    [nertdtree-git-status] job[init] failed: warning: could not open directory 'subdirname/dir1': Permission deniedwarning: could not open directory 'subdirname/dir2': Permission deniedwarning: could not open directory 'subdirname/dir3': Permission deniedwarning: could not open directory 'subdirname/dir4': Permission deniedwarning: could not open directory 'subdirname/dir5': Permission deniedwarning: could not open directory 'subdirname/dir6': Permission deniedwarning: could not open directory 'subdirname/dir7': Permission deniedwarning: could not open directory 'subdirname/dir8': Permission denied

ii) the git status icons which are normally displayed, are not displayed; even for other directories

Expected Result

git status icons are displayed